fix(csrc): report per-key native SET results - #12
Conversation
do_batch_set recorded no per-key results and aborted the tile at the first failure; completions moved per_key_results only for EXISTS, GET, and DELETE. Partial store failures were therefore invisible to Python: a batch either looked fully successful or carried a bare ok=false with no way to tell which keys made it to storage. Record a per-key result for every key in a SET tile (continuing past failures), include SET in the completion's per-key result move, and pre-allocate the result vector in submit_batch_set. Batch-level ok=false semantics are preserved by rethrowing after recording, so consumers that ignore per-key results see no behavior change. The Mooncake connector already receives per-key results from batch_put_from and now records them before failing the tile.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
2 participants
Summary
Native connector SET batches currently stop at the first failed key and expose only a batch-level failure. Python cannot tell which earlier keys were durably stored, so capacity accounting and writeback recovery can become inconsistent.
This PR:
ok=falsefor existing consumers;batch_put_from;[success, failure, success]behavior within one tile.The implementation commits retain Florian Bernd's authorship; the added regression test was developed during the release audit.
Validation
ruff checkandruff format --checkpass.Scope
This PR only establishes the native per-key completion contract. Python consumption, synchronous durability, restart accounting, and writeback are intentionally split into separate PRs.