Skip to content

Name the clan that player's are not whitelisted to#864

Merged
spaghetti-squash merged 3 commits into
loathers:mainfrom
libraryaddict:patch-2
Jun 10, 2026
Merged

Name the clan that player's are not whitelisted to#864
spaghetti-squash merged 3 commits into
loathers:mainfrom
libraryaddict:patch-2

Conversation

@libraryaddict

Copy link
Copy Markdown
Contributor

Naming the clan in the error would reduce the number of reports being made, and make it easier to debug where the issue is. This isn't the first time I wished it named the clan while helping a user figure out why a script broke.

@spaghetti-squash spaghetti-squash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably use clanName rather than clanIdOrName, right?

@libraryaddict

Copy link
Copy Markdown
Contributor Author

That's just const clanName = clanIdOrName.toLowerCase();

@spaghetti-squash spaghetti-squash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, you're right, I didn't catch that this only happens in the branch where the id is a string.

@spaghetti-squash spaghetti-squash merged commit 4423d6f into loathers:main Jun 10, 2026
4 checks passed
github-actions Bot pushed a commit that referenced this pull request Jun 10, 2026
Name the clan that player's are not whitelisted to
@libraryaddict libraryaddict deleted the patch-2 branch June 10, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants