Skip to content

chore: update pull request template - #2645

Open
7ui77 wants to merge 1 commit into
lnreader:masterfrom
7ui77:update-pr-template
Open

7ui77 wants to merge 1 commit into
lnreader:masterfrom
7ui77:update-pr-template

Conversation

@7ui77

@7ui77 7ui77 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Low risk] Updates the pull request template text.

The PR appears safe to merge, though the new check-results prompts would be clearer with usable links and guidance on when to skip them.

Findings

  1. P2 PR links render as code ▶
  2. P2 Some prompts cannot be filled ▶

Summary

The pull request template adds prompts for describing the work and recording check results. It keeps the existing checklist and adds fields for links and before-and-after images.

  • Pull requests now have prompts for descriptions and check results.

Reviews (1) · Last reviewed commit: "chore: update pull request template" · Reviewed by Greptile

Comment on lines +16 to +17
```
<!-- Link repo URL here -->

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR links render as code

The new URL placeholders are inside code blocks, so they appear as text in the PR body instead of disappearing. URLs entered there also won't be clickable. Put the prompts outside the code blocks and let contributors enter ordinary Markdown links.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

```
<!-- Link repo URL here -->
```
Link novel:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Some prompts cannot be filled

The template asks every contributor for a novel link and before-and-after images. A new plugin has no earlier state, and the self-hosted KomgaPlugin has no public novel URL. Mark these prompts as optional or say when to skip them, so contributors don't have to leave unexplained blanks or provide unrelated examples.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant