Skip to content

fix(english): fix WTR-LAB only showing [image] instead of images - #2641

Merged
rajarsheechatterjee merged 2 commits into
lnreader:masterfrom
7ui77:master
Oct 6, 2026
Merged

rajarsheechatterjee merged 2 commits into
lnreader:masterfrom
7ui77:master

Conversation

@7ui77

@7ui77 7ui77 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Previously in WTR-LAB, chapter illustrations were not rendered because parseChapter() only wrapped text lines in <p> tags without handling content.images. As a result, the app only showed literal [image] text instead of the actual illustration images.

Changes

  • Updated ChapterContent type to include images?: string[].
  • Replaced [image] placeholders with <img src="..." /> using the corresponding image URLs from content.images.
  • Handled relative / protocol-relative / absolute image URLs safely.
  • Appended any remaining unreferenced images to the end of the chapter (matching the behavior of the official WTR-LAB reader).
  • Bumped WTR-LAB plugin version from 1.2.3 to 1.2.4.

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Check results

Link: https://wtr-lab.com/en/novel/63082/i-let-you-tame-beasts-and-youve-already-formed-a-contract-with-your-stunningly-beautiful-master/chapter-9
Before:
Screenshot_2026-10-06-19-56-50-894_com rajarsheechatterjee LNReader
After:
Screenshot_2026-10-06-20-14-05-335_com rajarsheechatterjee LNReader

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 3/5

[Medium risk] Fixes image handling in a content parser plugin.

The PR is not safe to merge until chapter image URLs are escaped before they enter HTML.

Findings

  1. P1 Security Image URLs can run code ▶

Summary

WTR-LAB chapters now show illustrations in place of [image] markers, and chapter titles expand glossary markers into their terms. The plugin also accepts image URLs in chapter data and updates its version.

  • WTR-LAB chapters show images where image markers appear.
  • Chapter titles now replace glossary markers with their terms.

Reviews (1) · Last reviewed commit: "fix(english): fix WTR-LAB only showing [..."

Comment thread plugins/english/wtrlab.ts Outdated
@rajarsheechatterjee
rajarsheechatterjee merged commit a776784 into lnreader:master Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants