fix(multisrc): fix FreeWebNovel cover images failing to load (#2577) - #2626
Conversation
…ink protection - Add imageRequestInit with site Referer header to bypass Cloudflare image hotlink blocks in app image loader - Support data-cfsrc and data-original attributes in parseNovels and parseNovel to extract actual covers instead of data URI placeholders - Bump versionIncrements for FWN.com to 5 Closes lnreader#2577
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const cover = | ||
| attribs.src ?? attribs['data-cfsrc'] ?? attribs['data-src']; | ||
| attribs['data-src'] || | ||
| attribs['data-cfsrc'] || | ||
| attribs['data-original'] || | ||
| attribs.src; | ||
| const name = attribs.title; | ||
| if (cover) { | ||
| if (cover && !cover.startsWith('data:')) { | ||
| novel.cover = new URL(cover, this.site).href; |
There was a problem hiding this comment.
If a novel page has an inline placeholder in data-src and a real cover URL in src, this code picks the placeholder, rejects it, and never tries src. The novel loses its cover. Skip placeholders while choosing an image URL so the code can try the next attribute.
| "chapterListing": "api/chapterlist.php", | ||
| "chapterParam": "aid", | ||
| "versionIncrements": 4, | ||
| "versionIncrements": 5, |
There was a problem hiding this comment.
The shared template changes the generated code for all eight sources, but only FWN.com gets a new version. If the app uses that version to offer updates, users with the other seven sources will not be offered the changed plugin. Bump those versions too, or limit the shared change to FWN.com.
…scoped referer header
2 participants
Closes #2577
Refererheader toimageRequestInitinreadnovelfullmultisrc template to unblock hotlink protectiondata-cfsrcanddata-originalimage attributes and filter out inlinedata:base64 placeholdersChecklist