Skip to content

fix(english): fix AO3 works not loading (#2622) #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajarsheechatterjee merged 4 commits into from
Oct 4, 2026
Merged

fix(english): fix AO3 works not loading (#2622) #2625

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e02c49
fix(english/ao3): bypass adult warning barrier and fix single chapter…
52191314 Oct 2, 2026
93a9bb6
fix(english/ao3): forward adult consent cookie in popular and search …
52191314 Oct 2, 2026
d49a981
fix(english/ao3): handle rate limiting and fix navigation URL path
52191314 Oct 2, 2026
7cf9a5b
fix(english/ao3): classify 5xx server errors as transient timeouts
52191314 Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 81 additions & 105 deletions plugins/english/ao3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,28 @@ import { Plugin } from '@/types/plugin';
import { Filters, FilterTypes } from '@libs/filterInputs';
import { defaultCover } from '@libs/defaultCover';

function checkResponse(res: Response, body: string, context: string) {
if (!res.ok) {
if (res.status >= 500 || res.status === 429 || res.status === 403) {
throw Object.assign(
new Error(`AO3 request timed out / blocked: HTTP ${res.status}`),
{ status: res.status, response: res },
);
}
throw new Error(`Failed to ${context}: HTTP ${res.status}`);
}
if (body.includes('Retry later')) {
throw Object.assign(
new Error('AO3 rate limit: request timed out by server (Retry later)'),
{ status: 429, response: res },
);
}
}

class ArchiveOfOurOwn implements Plugin.PluginBase {
id = 'archiveofourown';
name = 'Archive Of Our Own';
version = '1.0.4';
version = '1.0.5';
icon = 'src/en/ao3/icon.png';
site = 'https://archiveofourown.org/';

Expand Down Expand Up @@ -109,17 +127,33 @@ class ArchiveOfOurOwn implements Plugin.PluginBase {
}

const link = `${this.site}works/search?${params.toString()}`;
const body = await fetchApi(link).then(r => r.text());
const res = await fetchApi(link, {
headers: { Cookie: 'view_adult=true' },
});
const body = await res.text();
checkResponse(res, body, 'fetch popular novels');
const loadedCheerio = parseHTML(body);
return this.parseNovels(loadedCheerio);
}

async parseNovel(novelUrl: string): Promise<Plugin.SourceNovel> {
const result = await fetchApi(new URL(novelUrl, this.site).toString());
const urlchapter = novelUrl + '/navigate';
const chapters = await fetchApi(new URL(urlchapter, this.site).toString());
const novelHttpUrl = new URL(novelUrl, this.site);
novelHttpUrl.searchParams.set('view_adult', 'true');
const navHttpUrl = new URL(
novelHttpUrl.pathname.replace(/\/$/, '') + '/navigate',
this.site,
);
Comment on lines +142 to +145

@greptile-apps greptile-apps Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Work URLs lose chapters

When someone enters a work URL with a query string or fragment, parseNovel adds /navigate after that suffix instead of to the work path. It fetches the work page rather than the chapter list, then shows a multi-chapter work as one chapter. Build the navigation URL from the parsed URL’s path.

navHttpUrl.searchParams.set('view_adult', 'true');
const headers = { Cookie: 'view_adult=true' };

const [result, chapters] = await Promise.all([
fetchApi(novelHttpUrl.toString(), { headers }),
fetchApi(navHttpUrl.toString(), { headers }),
]);
const body = await result.text();
const chapterlisttext = await chapters.text();
checkResponse(result, body, 'fetch novel details');
checkResponse(chapters, chapterlisttext, 'fetch novel chapters');
const chapterlistload = parseHTML(chapterlisttext);
const loadedCheerio = parseHTML(body);

Expand Down Expand Up @@ -163,115 +197,51 @@ class ArchiveOfOurOwn implements Plugin.PluginBase {
.map(el => loadedCheerio(el).text().trim())
.join(',');
novel.summary = `Fandom:\n${fandom}\n\nRating:\n${rating}\n\nWarning:\n${warning}\n\nSummary:\n${summary}\n\nSeries:\n${series}\n\nRelationships:\n${relation}\n\nCharacters:\n${character}\n\nStats:\n${stats}`;

const chapterItems: Plugin.ChapterItem[] = [];
const longReleaseDate: string[] = [];
// let match: RegExpExecArray | null;
chapterlistload('ol.index').each((i, ele) => {
chapterlistload(ele)
.find('li')
.each((i, el) => {
// const chapterNameMatch = chapterlistload(el).find('a').text().trim();
const releaseTimeText = chapterlistload(el)
.find('span.datetime')
.text()
.replace(/\(([^)]+)\)/g, '$1')
.trim();
const releaseTime = releaseTimeText
? new Date(releaseTimeText).toISOString()
: '';
longReleaseDate.push(releaseTime);
});
});
const releaseTimeText = loadedCheerio('.wrapper dd.published')
.text()
.trim();
const releaseTime = releaseTimeText
? new Date(releaseTimeText).toISOString()
: '';
let dateCounter = 0;
if (loadedCheerio('#chapter_index select').length > 0) {
loadedCheerio('#chapter_index select').each((i, selectEl) => {
loadedCheerio(selectEl)
.find('option')
.each((i, el) => {
const chapterName = loadedCheerio(el).text().trim();
const chapterUrlCode = loadedCheerio(el).attr('value')?.trim();
const chapterUrl = `${novelUrl}/chapters/${chapterUrlCode}`;
const releaseDate: string = longReleaseDate[dateCounter];
dateCounter++;
if (chapterUrl) {
chapterItems.push({
name: chapterName,
path: chapterUrl,
releaseTime: releaseDate,
});
}
});
chapterlistload('ol.index li').each((i, el) => {
const a = chapterlistload(el).find('a');
const href = a.attr('href')?.trim();
if (!href) return;
const releaseTimeText = chapterlistload(el)
.find('span.datetime')
.text()
.replace(/[()]/g, '')
.trim();
chapterItems.push({
name: a.text().trim() || `Chapter ${i + 1}`,
path: href.replace(/^\//, ''),
releaseTime: releaseTimeText
? new Date(releaseTimeText).toISOString()
: null,
});
}
if (chapterItems.length === 0) {
loadedCheerio('#chapters h3.title').each((i, titleEl) => {
const fullTitleText = loadedCheerio(titleEl).text().trim();
const chapterNameMatch = fullTitleText.match(/:\s*(.*)$/);
let chapterName = chapterNameMatch ? chapterNameMatch[1].trim() : '';
const chapterUrlRaw = loadedCheerio(titleEl)
.find('a')
.attr('href')
?.trim();
const chapterUrlCode = chapterUrlRaw?.match(/\/chapters\/(\d+)/)?.[1];
const chapterUrl = `${novelUrl}/chapters/${chapterUrlCode}`;
});

if (chapterUrl) {
if (chapterName === '') {
const novelTitle = loadedCheerio('.work .title.heading')
.text()
.trim();
chapterName = novelTitle;
}
chapterItems.push({
name: chapterName,
path: chapterUrl,
releaseTime: releaseTime,
});
}
if (chapterItems.length === 0) {
const releaseTimeText = loadedCheerio('.wrapper dd.published')
.text()
.trim();
chapterItems.push({
name: novel.name,
path: novelUrl,
releaseTime: releaseTimeText
? new Date(releaseTimeText).toISOString()
: null,
});
if (chapterItems.length === 0) {
loadedCheerio('.work.navigation.actions li a').each((i, el) => {
const href = loadedCheerio(el).attr('href');
if (href && href.includes('/downloads/')) {
const chapterUrlCodeMatch = href.match(/updated_at=(\d+)/);
const chapterUrlCode = chapterUrlCodeMatch
? chapterUrlCodeMatch[1]
: null;
let chapterName = loadedCheerio('h2.title.heading').text().trim();

const chapterUrl = `${novelUrl}/chapters/${chapterUrlCode}`;

if (chapterUrl) {
if (chapterName === '') {
const novelTitle = loadedCheerio('.work .title.heading')
.text()
.trim();
chapterName = novelTitle;
}
chapterItems.push({
name: chapterName,
path: chapterUrl,
releaseTime: releaseTime,
});
}
}
});
}
}
novel.chapters = chapterItems;

novel.chapters = chapterItems;
return novel;
}

async parseChapter(chapterUrl: string): Promise<string> {
const result = await fetchApi(new URL(chapterUrl, this.site).toString());
const chapterHttpUrl = new URL(chapterUrl, this.site);
chapterHttpUrl.searchParams.set('view_adult', 'true');
const result = await fetchApi(chapterHttpUrl.toString(), {
headers: { Cookie: 'view_adult=true' },
});
const body = await result.text();
checkResponse(result, body, 'fetch chapter');

const loadedCheerio = parseHTML(body);

Expand All @@ -289,7 +259,10 @@ class ArchiveOfOurOwn implements Plugin.PluginBase {
});
loadedCheerio('h3.landmark.heading#work').remove();

const chapterText = loadedCheerio('div#chapters > div').html() || '';
const chapterText =
loadedCheerio('div#chapters > div').html() ||
loadedCheerio('div#chapters').html() ||
'';

return chapterText;
}
Expand All @@ -306,8 +279,11 @@ class ArchiveOfOurOwn implements Plugin.PluginBase {
});
const searchUrl = `${this.site}works/search?${params.toString()}`;

const result = await fetchApi(searchUrl);
const result = await fetchApi(searchUrl, {
headers: { Cookie: 'view_adult=true' },
});
const body = await result.text();
checkResponse(result, body, 'search novels');

const loadedCheerio = parseHTML(body);
return this.parseNovels(loadedCheerio);
Expand Down
Loading