Skip to content

feat: Add Skythewood translations - #2363

Merged
K1ngfish3r merged 6 commits into
lnreader:masterfrom
creeperkafasi:master
Jul 31, 2026
Merged

K1ngfish3r merged 6 commits into
lnreader:masterfrom
creeperkafasi:master

Conversation

@creeperkafasi

Copy link
Copy Markdown
Contributor

This PR adds support for Skythewood Translations

I didn't really check every single novel that gets scraped, but i know some novels don't show up and some might not even work. "Too many losing heroines" works, i tested it.
Scraping the website was messy because it doesn't seem to have much of a rigid structure to it, especially with older projects.

better than nothing i guess ~('v')~

I'd appreciate it if you could squash these commits before merging

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)

@creeperkafasi creeperkafasi changed the title Add Skythewood translations feat: Add Skythewood translations Jul 30, 2026

@K1ngfish3r K1ngfish3r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing metadata for now is ok, can try fixing the rest of the novels later
fix these issues and i squash

Comment thread plugins/english/skythewood.ts Outdated
Comment thread plugins/english/skythewood.ts Outdated
Comment thread plugins/english/skythewood.ts Outdated
@K1ngfish3r

Copy link
Copy Markdown
Collaborator

technically, we use this.site and keep paths separate so that if the site changes domain the users' chapter lists won't be affected when the URL is updated, but looking at the fact that this is a blogspot site, we can probably keep full paths, changing the website domain would probably massively update the layout to the point where a massive refactor would be required. but your call

@creeperkafasi

Copy link
Copy Markdown
Contributor Author

technically, we use this.site and keep paths separate so that if the site changes domain the users' chapter lists won't be affected when the URL is updated, but looking at the fact that this is a blogspot site, we can probably keep full paths, changing the website domain would probably massively update the layout to the point where a massive refactor would be required. but your call

I agree with you on the layout change. But they don't seem to have changed their domain since 2014 which is the earliest instance of the blog being used as a tl site on archive.org, so i think it's safe to assume they aren't going anywhere or changing their layout

@creeperkafasi

Copy link
Copy Markdown
Contributor Author

Fixed and tested with your in editor suggestions applied, thanks

@K1ngfish3r

K1ngfish3r commented Jul 31, 2026 •

Copy link
Copy Markdown
Collaborator

technically, we use this.site and keep paths separate so that if the site changes domain the users' chapter lists won't be affected when the URL is updated, but looking at the fact that this is a blogspot site, we can probably keep full paths, changing the website domain would probably massively update the layout to the point where a massive refactor would be required. but your call

I agree with you on the layout change. But they don't seem to have changed their domain since 2014 which is the earliest instance of the blog being used as a tl site on archive.org, so i think it's safe to assume they aren't going anywhere or changing their layout

oops, i checked the epub logic, it uses resolveUrl which would prepend the this.site to the url... i think...
might need refactor

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

oops, i checked the epub logic, it uses resolveUrl which would prepend the this.site to the url... i think... might need refactor

ignore this crap, epubs are already downloaded, can skip refactor

@K1ngfish3r
K1ngfish3r merged commit bb2e9d7 into lnreader:master Jul 31, 2026
2 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants