Repository navigation
Feat rewayatfans - #2328
Closed
hamedhani1998 wants to merge 3 commits into
Closed
Feat rewayatfans#2328hamedhani1998 wants to merge 3 commits into
hamedhani1998 wants to merge 3 commits into
Conversation
- WordPress REST API for novel listing and search - Cover images via _embed - Chapter ordering by number
hamedhani1998
force-pushed
the
feat-rewayatfans
branch
from
July 18, 2026 17:23
8e58a10 to
a0d9314
Compare
rajarsheechatterjee
requested changes
Jul 21, 2026
rajarsheechatterjee
left a comment
rajarsheechatterjee
left a comment
Member
There was a problem hiding this comment.
This review was generated by Codex.
Codex found the following structural issues that should be addressed before merging:
plugins/arabic/rewayatfans.ts:5-13,123-124: This change removescontentfromWPPage, butparseChapterstill readsarr[0].content.rendered. A strict type-check now reports TS2339 on both accesses. Restorecontent: { rendered: string }(or use a separate response type that includes it) so the chapter response matches the code that consumes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist