fix: exponential backoff for preimage polling to avoid relay rate limiting#52
Open
dadofsambonzuki wants to merge 1 commit into
Open
fix: exponential backoff for preimage polling to avoid relay rate limiting#52dadofsambonzuki wants to merge 1 commit into
dadofsambonzuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The preimage polling loop in
_process_invoicecheckscheck_transaction_statusevery 50ms (await asyncio.sleep(0.05)). When the LNbits instance uses an NWC wallet as its funding source, each poll triggers one or more WebSocket calls to the external relay, easily exceeding the relay's rate limit (~20 req/s). Once the relay activates its "pubkey flood" rate limiter, all traffic from the LNbits IP is blocked, including NWC client connections -- which then fail with "all promises were rejected" on the Alby side.Fix
Impact
Peak event rate drops from ~20 req/s to ~1 req/s, well within normal relay limits. The rate-limit cascade is avoided entirely.