arith: replace string predicates with CmpIPredicate enums in ArithVal… - #707
Open
viniciusfdasilva wants to merge 1 commit into
Open
viniciusfdasilva wants to merge 1 commit into
viniciusfdasilva wants to merge 1 commit into
Conversation
makslevental
self-requested a review
September 25, 2026 02:42
|
|
||
|
|
||
| canonicalizer = ArithCanonicalizer() | ||
| canonicalizer = ArithCanonicalizer() No newline at end of file |
Contributor
There was a problem hiding this comment.
can you restore the newline here
| if isinstance(lhs.dtype, FloatType): | ||
| # ordered comparison - see above | ||
| predicate = "o" + predicate | ||
| enum_predicate = _CMPF_PREDICATES[predicate][0] |
Contributor
There was a problem hiding this comment.
Suggested change
| enum_predicate = _CMPF_PREDICATES[predicate][0] | |
| enum_predicate, _ = _CMPF_PREDICATES[predicate] |
makslevental
left a comment
makslevental
left a comment
Contributor
There was a problem hiding this comment.
looks like you have some issues
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
ArithValue's comparison operators to dispatch onCmpIPredicateenum members instead of ad-hoc strings, removing the string-based predicate mini-language while preserving existing signed/unsigned and int/float resolution behavior.Resolves #230