feat(tracker): 使用卡牌技能 ID 识别牌种 - #111
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough本次变更为 Changes基于技能 ID 的卡牌识别
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Card identification now uses stable skill IDs rather than display names, preserving FenChao selection and Slash color statistics when names vary. No concrete current-head merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
变更内容
卡牌识别原先依赖中文牌名与简称。为
BaseCard增加从CardConfig加载的spellId,焚巢筛牌和红黑杀统计改按卡牌技能 ID 判断,使显示名变化后仍能正确识别。1、决斗8、南蛮入侵9、万箭齐发10、火攻83。setCardInfo同步刷新卡牌技能 ID;匿名牌或配置缺失时使用0。验证
pnpm lintpnpm typecheck:trackerpnpm test:tracker:62 个测试文件、583 项测试通过pnpm buildpnpm build:prodgit diff --check风险与备注
spellId表示卡牌自身技能 ID,独立于移动协议、标记区使用的Card.spellID;回归覆盖焚巢移动后两者分别保留自身值。Summary by CodeRabbit
Bug 修复
文档
测试