address some issues raised concerning half power exponents for meter - #464
Open
phlptp wants to merge 13 commits into
Open
address some issues raised concerning half power exponents for meter#464phlptp wants to merge 13 commits into
phlptp wants to merge 13 commits into
Conversation
… which is a valid unit. allow more complete processing of valid units with half power and decimals in the exponent
for more information, see https://pre-commit.ci
…into half_power_exponents
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into half_power_exponents
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
===========================================
- Coverage 100.00% 99.84% -0.16%
===========================================
Files 9 9
Lines 5207 5289 +82
Branches 1007 1019 +12
===========================================
+ Hits 5207 5281 +74
- Misses 0 8 +8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #462
Adds processing for exponents in parenthesis and some other valid decimals as long as they can be defined in the library. and produce errors on others that can't instead of dropping back to multiplication