Repository navigation
feature: introduce clang frontend to detect illegal usage of C++ proteus functions - #540
Merged
Merged
Conversation
johnbowen42
marked this pull request as draft
September 30, 2026 22:34
Member
|
This is a great idea. Looks good to me. |
Collaborator
Author
|
resolves #530 |
johnbowen42
commented
Oct 1, 2026
| ) | ||
| endif() | ||
|
|
||
| add_dependencies(${target} ProteusPass ProteusASTChecker) |
Collaborator
Author
There was a problem hiding this comment.
NB: this dependency ordering is sometimes needed by downstream projects, so even though this feature does not require ProteusPass dependency explicitly, some downstream projects will benefit from this
johnbowen42
marked this pull request as ready for review
October 1, 2026 19:40
Collaborator
Author
|
@ZwFink What do you think of this? You have more experience with the ClangAST than any of us |
Collaborator
|
@lc-hubcast restart pipeline |
|
I've started a new pipeline for you! |
ZwFink
force-pushed
the
feature/clang-frontend
branch
from
October 1, 2026 20:54
2449d74 to
902e31a
Compare
This was referenced Oct 1, 2026
ZwFink
force-pushed
the
feature/clang-frontend
branch
from
October 6, 2026 00:56
902e31a to
fc8f101
Compare
Collaborator
|
@lc-hubcast restart failed jobs |
|
I've retried any failed jobs in the pipeline! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the feature is to gracefully exit when a user illegally uses
proteus::register_lambdaorproteus::jit_variable. There are a variety of error messages attempting to handle these cases within Proteus's LLVM plugin pass, but this is not an ideal way to catch the misuses as they result in compiler crashes