Repository navigation
Fix GPU lambda constants for casted jit_variable captures - #535
Merged
Merged
Conversation
ZwFink
force-pushed
the
lambda-cast-capture-test
branch
from
September 30, 2026 21:17
9d15aab to
400cd72
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ZwFink
force-pushed
the
lambda-cast-capture-test
branch
2 times, most recently
from
October 7, 2026 23:33
36590b1 to
ce80195
Compare
ZwFink
force-pushed
the
lambda-cast-capture-test
branch
from
October 8, 2026 23:12
ce80195 to
eedef17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU lambda schema recorded the
jit_variableargument type instead of the closure slot type, so casted captures likeX = (double)jit_variable(F)were specialized with wrong values or crashed the JIT. This uses the slot type, matching host registration, and adds CPU and GPU tests (the GPU test fails onmain).