Repository navigation
Release/1.1.12 - #155
Merged
Merged
Release/1.1.12#155
Conversation
v1.1.11 is already tagged from main and published on PyPI, so this release needs a new version for PyPI to accept the upload.
Commit 0926f58 reintroduced assertions that expect printed output ("Using hour_angle", "cannot be negative"), but utils raises a UserWarning and a ValueError, so two tests failed. The fix itself is already on main; tests/test_hour_angle_regressions.py stays. Co-authored-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
1.1.10 bundled its data (254.7 MB sdist); 1.1.11 moved the data to the optional data extra, so a plain `pip install llnl-ssapy` installs no ephemeris or gravity files. CI did not catch this because it installs requirements.txt, which already lists the packages. The data packages are also renamed: ssatk-data-<name> (import ssapy_data_<name>) becomes ssa-data-<name> (import ssa_data_<name>), still at 0.0.1. - Require ssa-data-core, -gravity, -lunar and -lunar-gravity ==0.0.1; the data and all-data extras keep working with the new names - Add ssapy/_data_packages.py as the single list of import names; __init__ and utils previously hard-coded 4 and 6 names - _datadir(): return the in-tree fallback path, never None; find_file raised TypeError instead of FileNotFoundError without data installed - Name the install command in find_file and ephemeris errors - Add a regression test for the no-data-package path
- README: drop the duplicate intro sentence, move the SSATK pointer from Contributing to the introduction, replace the unquantified "higher-fidelity" with 6-DOF, note what moved to SSATK, and list the ssa-data packages under strict dependencies - installation.rst: data installs with SSAPy; all-data adds the propulsion and benchmark sets - skills.md: restore the rule that data goes in the split data repos, the distribution/import-name mapping, and the ssatk install name
# Conflicts: # docs/source/installation.rst # pyproject.toml # requirements.txt # skills.md # ssapy/__init__.py # ssapy/ephemeris.py # ssapy/utils.py # tests/test_accel.py # tests/test_data_file_lookup.py # tests/test_orbit.py # tests/test_tle_drag.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 99.23% 99.30% +0.07%
==========================================
Files 18 19 +1
Lines 6124 6129 +5
==========================================
+ Hits 6077 6086 +9
+ Misses 47 43 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.