Feature/smith84/cuda 13 support#2011
Draft
smithsg84 wants to merge 27 commits into
Draft
Conversation
rhornung67
reviewed
Apr 15, 2026
| @@ -0,0 +1,161 @@ | |||
| # Copyright Spack Project Developers. See COPYRIGHT file for details. | |||
Member
There was a problem hiding this comment.
Do you plan to have the camp package changes pushed up to the spack package repo?
Member
Author
There was a problem hiding this comment.
Yes, once CI tests are working PR for spack-packages / camp / BLT will be done.
rhornung67
approved these changes
Apr 15, 2026
rhornung67
requested review from
MrBurmark,
adayton1,
artv3,
johnbowen42 and
rchen20
rchen20
reviewed
Apr 15, 2026
Comment on lines
+1
to
+24
| diff --git a/include/camp/resource.hpp b/include/camp/resource.hpp | ||
| index 58df206..763aa20 100644 | ||
| --- a/include/camp/resource.hpp | ||
| +++ b/include/camp/resource.hpp | ||
| @@ -12,6 +12,7 @@ http://github.com/llnl/camp | ||
| #define __CAMP_RESOURCE_HPP | ||
|
|
||
| #include <cstring> | ||
| +#include <stdexcept> | ||
| #include <memory> | ||
| #include <mutex> | ||
| #include <type_traits> | ||
| diff --git a/include/camp/resource/host.hpp b/include/camp/resource/host.hpp | ||
| index c765175..4428c57 100644 | ||
| --- a/include/camp/resource/host.hpp | ||
| +++ b/include/camp/resource/host.hpp | ||
| @@ -13,6 +13,7 @@ http://github.com/llnl/camp | ||
|
|
||
| #include "camp/resource/event.hpp" | ||
| #include "camp/resource/platform.hpp" | ||
| +#include <cstdlib> | ||
|
|
||
| namespace camp | ||
| { |
Member
There was a problem hiding this comment.
Thanks for looking in to this, Steve! Should we just directly update Camp and release it, rather than patching it? Same question for BLT.
Member
Author
There was a problem hiding this comment.
That camp patch is in the upstream spack-packages repo, it is there to support building older versions of camp (pre camp 2022.10). Local copy was done to get CI build system working until camp can be updated for CUDA.
Member
Author
|
This PR fixes #1958 This PR depends on CAMP changes llnl/camp#196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to support CUDA 13
Doing PR to force a new Matrix CUDA 13 test.
There are currently files and TPL changes that need to be removed related to the TPLs. The spack packages, CAMP and BLT updates should be updated in the upstream repos. Local changes were made pending upstream fixes.
Requires updates for RAJA TPLs:
Updates for Cuda 13 and fixes for some issues with location of host-config.cmake file balos1/spack-packages#1
raja: fix tests spack/spack-packages#4435