Recoding cmake to use BLT - #195
Open
rblake-llnl wants to merge 40 commits into
Open
Conversation
lpottier
self-requested a review
June 3, 2026 23:14
I just checked out 0.7.1 manually. Please override as needed.
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
lpottier
approved these changes
Jul 29, 2026
lpottier
left a comment
lpottier
left a comment
Member
There was a problem hiding this comment.
LGTM. If tests are passing, we can merge.
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
…it objects Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.8
Click here for the full clang-format patch
diff --git a/tests/AMSlib/ams_catch_main.hpp b/tests/AMSlib/ams_catch_main.hpp
index 58ae712..e72dac6 100644
--- a/tests/AMSlib/ams_catch_main.hpp
+++ b/tests/AMSlib/ams_catch_main.hpp
@@ -27 +27 @@ inline int runCatchSession(int argc, char** argv, bool finalizeAMS = true)
-}
+} // namespace ams::test
diff --git a/tests/AMSlib/ams_interface/ams_ete.cpp b/tests/AMSlib/ams_interface/ams_ete.cpp
index 6802559..5b64484 100644
--- a/tests/AMSlib/ams_interface/ams_ete.cpp
+++ b/tests/AMSlib/ams_interface/ams_ete.cpp
@@ -14 +13,0 @@
-#include <cstdio>
@@ -15,0 +15 @@
+#include <cstdio>
diff --git a/tests/AMSlib/wf/evaluate_in_and_outs.cpp b/tests/AMSlib/wf/evaluate_in_and_outs.cpp
index 3370f49..2f7630e 100644
--- a/tests/AMSlib/wf/evaluate_in_and_outs.cpp
+++ b/tests/AMSlib/wf/evaluate_in_and_outs.cpp
@@ -11,0 +12 @@
+#include <cstdint>
@@ -14 +14,0 @@
-#include <cstdint>
Have any feedback or feature suggestions? Share it here.
| const int normalizedRC = (rc == 0 || rc == 4) ? EXIT_SUCCESS : rc; | ||
| std::_Exit(normalizedRC); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| } | |
| } // namespace ams::test |
| @@ -11,6 +11,7 @@ | |||
| #include <catch2/interfaces/catch_interfaces_reporter.hpp> | |||
| #include <catch2/reporters/catch_reporter_event_listener.hpp> | |||
| #include <catch2/reporters/catch_reporter_registrars.hpp> | |||
| #include <cstdio> | |||
Contributor
There was a problem hiding this comment.
clang-format suggestion
Please remove the line(s)
- 14
| @@ -11,6 +11,7 @@ | |||
| #include <catch2/interfaces/catch_interfaces_reporter.hpp> | |||
| #include <catch2/reporters/catch_reporter_event_listener.hpp> | |||
| #include <catch2/reporters/catch_reporter_registrars.hpp> | |||
| #include <cstdio> | |||
| #include <cstdint> | |||
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| #include <cstdint> | |
| #include <cstdio> |
| @@ -9,6 +9,8 @@ | |||
| #include <catch2/interfaces/catch_interfaces_reporter.hpp> | |||
| #include <catch2/reporters/catch_reporter_event_listener.hpp> | |||
| #include <catch2/reporters/catch_reporter_registrars.hpp> | |||
| #include <cstdio> | |||
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| #include <cstdio> | |
| #include <cstdint> |
| @@ -9,6 +9,8 @@ | |||
| #include <catch2/interfaces/catch_interfaces_reporter.hpp> | |||
| #include <catch2/reporters/catch_reporter_event_listener.hpp> | |||
| #include <catch2/reporters/catch_reporter_registrars.hpp> | |||
| #include <cstdio> | |||
| #include <cstdlib> | |||
| #include <cstdint> | |||
Contributor
There was a problem hiding this comment.
clang-format suggestion
Please remove the line(s)
- 14
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recoded things here to use BLT everywhere. This is a complete redesign of the Cmakefile and export system.
In particular, I've added flags so that we can link in AMS in a large multiphysics code. The flags I"m using are: