Skip to content

Fix secret-scan false positives in test fixtures #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwisatzh merged 2 commits into from
Oct 5, 2026
Merged

Fix secret-scan false positives in test fixtures #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74a9d6b
Scope secret-scan exceptions to synthetic test fixtures
kwisatzh Oct 5, 2026
c90aadd
Use a patched Go fuzz runner for scheduled security tests
kwisatzh Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ jobs:
fetch-depth: 0
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: '1.26.8'
# Fixes timed-fuzz cancellation failures: https://go.dev/issue/75804.
go-version: '1.27.1'
- run: go run golang.org/x/vuln/cmd/govulncheck@v1.6.0 ./...
- name: Redacted history secret scan
run: go run github.com/zricethezav/gitleaks/v8@v8.30.1 git --redact --log-opts=--all --no-banner .
run: go run github.com/zricethezav/gitleaks/v8@v8.30.1 git --redact=100 --verbose --log-opts=--all --no-banner .
- name: Extended malformed-input testing
run: |
go test ./internal/compare -run '^$' -fuzz '^FuzzCanonicalSummary$' -fuzztime 2m -parallel 2
Expand Down
12 changes: 12 additions & 0 deletions .gitleaksignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# SPDX-License-Identifier: Apache-2.0
# Code authors: Vijay and Codex
# Reviewed synthetic test data only. Each exception is bound to one commit,
# file, rule, and line; new occurrences still require review.

# Dummy hashing secret used only by the isolated collector config validator.
b214e8466291879aa7862f7d26875778ee20ea95:.github/workflows/ci.yml:generic-api-key:61
b214e8466291879aa7862f7d26875778ee20ea95:internal/diagnose/shadow_test.go:generic-api-key:43

# Planted sentinels asserting that CLI and config input never enters reports.
b214e8466291879aa7862f7d26875778ee20ea95:internal/cli/diagnose_test.go:generic-api-key:85
b214e8466291879aa7862f7d26875778ee20ea95:internal/diagnose/diagnose_test.go:generic-api-key:65
Loading