Skip to content

diagnose: support memory_limiter percentages - #26

Open
sb123sb123 wants to merge 1 commit into
llm-measurement:mainfrom
sb123sb123:fix/24-memory-limiter-percentages
Open

sb123sb123 wants to merge 1 commit into
llm-measurement:mainfrom
sb123sb123:fix/24-memory-limiter-percentages

Conversation

@sb123sb123

Copy link
Copy Markdown

Closes #24.

Teach diagnose to recognize OpenTelemetry Collector's limit_percentage and spike_limit_percentage settings for memory_limiter. The static checks enforce the pinned Collector v0.161.0 rules: at least one nonzero limit, percentage values in the accepted range, and each configured spike limit below its matching limit. A nonzero limit_mib retains precedence, while configured percentage fields are still validated.

The report continues to identify invalid fields by YAML path and line without including their values. Unknown settings remain indeterminate. The documentation states that this is a static configuration check and does not assess host memory sufficiency.

Validation on remote Windows via WSL Ubuntu 22.04 with Go 1.26.8:

  • go test ./internal/diagnose ./internal/cli -count=1
  • go vet ./...
  • gofmt check and git diff --check

@kwisatzh

kwisatzh commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

thanks! will review this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diagnose: support percentage-based memory_limiter settings

2 participants