Repository navigation
diagnose: support memory_limiter percentages - #26
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
Contributor
|
thanks! will review this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Teach
diagnoseto recognize OpenTelemetry Collector'slimit_percentageandspike_limit_percentagesettings formemory_limiter. The static checks enforce the pinned Collector v0.161.0 rules: at least one nonzero limit, percentage values in the accepted range, and each configured spike limit below its matching limit. A nonzerolimit_mibretains precedence, while configured percentage fields are still validated.The report continues to identify invalid fields by YAML path and line without including their values. Unknown settings remain indeterminate. The documentation states that this is a static configuration check and does not assess host memory sufficiency.
Validation on remote Windows via WSL Ubuntu 22.04 with Go 1.26.8:
go test ./internal/diagnose ./internal/cli -count=1go vet ./...gofmtcheck andgit diff --check