Skip to content

feat: generate a random seed if none given#259

Open
WereCatf wants to merge 1 commit into
lllyasviel:mainfrom
WereCatf:randomseed
Open

feat: generate a random seed if none given#259
WereCatf wants to merge 1 commit into
lllyasviel:mainfrom
WereCatf:randomseed

Conversation

@WereCatf

Copy link
Copy Markdown

Currently the UI defaults to "31337" for the seed value but the code causes an exception if there is no value set for seed. This commit simply generates a new seed and updates the UI accordingly in that case, preventing the exception.

@chuckkay

Copy link
Copy Markdown

I think if you open demo_gradio.py in a text editor and change seed to '-1' i think that is the same thing. However you can't see what the random number is, so maybe your approach is better

@yar85

yar85 commented Apr 26, 2025

Copy link
Copy Markdown

I think if you open demo_gradio.py in a text editor and change seed to '-1' i think that is the same thing.

As far as I understand, it's not the same thing:

Negative inputs are remapped to positive values with the formula 0xffff_ffff_ffff_ffff + seed.

docs

@chuckkay

Copy link
Copy Markdown

new random seed generation code implemented

@WereCatf

WereCatf commented May 1, 2025

Copy link
Copy Markdown
Author

@chuckkay Stop spamming. Your comment has nothing to do with this pull request and is entirely irrelevant.

@chuckkay

chuckkay commented May 2, 2025

Copy link
Copy Markdown

@chuckkay Stop spamming. Your comment has nothing to do with this pull request and is entirely irrelevant.

nothing to do with the pull request? entirely irrelivant? its a mod that has random seed generation done perfectly and many other features. considering pull requests have not been processed in a while, i am offering people a mod that does them all and in a better way..

@WereCatf

WereCatf commented May 2, 2025

Copy link
Copy Markdown
Author

@chuckkay I don't care, it's not relevant to this pull request. Go spam someone else.

@Fabrice-TIERCELIN

Copy link
Copy Markdown

@WereCatf, I suggest you to apply this change also on demo_gradio_f1.py to make the code consistent.

Currently the UI defaults to "31337" for the seed value but
the code causes an exception if there is no value set for
seed. This commit simply generates a new seed and updates
the UI accordingly in that case, preventing the exception.
kolessios pushed a commit to opendreamnet/framepack-serverless that referenced this pull request Aug 25, 2025
…ker-hub

Remove cleanup and push to docker hub instead of GHCR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants