Repository navigation
ci: install WAMR for WASI standard-library jobs - #29
Merged
cpunion merged 1 commit intoOct 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard-library workflow installs Wasmtime but never installs WAMR. Since LLGo #2697 made WAMR threads the default W32 backend, every W32-WASI package fails to launch with
exec: "iwasm": executable file not found in $PATH. The same missing executable also fails the WASI GOROOT sentinels. The report in #28 contains 190 W32 package failures from this single setup omission.Restore the checked-out LLGo revision's WAMR cache and run its pinned
dev/build_iwasm.shin both the W32-WASI acceptance jobs and the GOROOT sentinel job. The builder checks its source/patch build identity and exports the executable directory throughGITHUB_PATH. Cache restoration is limited to WAMR; Wasmtime remains available for reference tooling.Refs #28. The three independent J32-GoJS host-check failures also require the LLGo acceptance-child runner fix in xgo-dev/llgo#2718.
Validation:
actionlint .github/workflows/std.ymlandgit diff --check.dev/build_iwasm.shinstaller withGITHUB_PATHset; it selected the matching cached binary and exported the expected directory.bom.goandhelloworld.go(the two previously failing sentinels).test(39 tests),test/go(242 tests), andtest/llgoext(24 tests), selecting one whole package per shard (0,9, and17of201). All three packages and all 14 host checks passed, including builtin print, panic/repanic locations, invalid-finalizer diagnostics, and main-Goexit lifecycle. This was targeted validation of the affected execution paths; the complete 190-package W32 audit was not rerun locally.