Skip to content

test(file-tree): wait for the star to change, not for the button to exist #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adnaan merged 1 commit into from
Jul 19, 2026
Merged

test(file-tree): wait for the star to change, not for the button to exist #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion examples/file-tree/file_tree_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,12 @@ func TestFileTreeE2E(t *testing.T) {
var starred, siblingSurvived bool
if err := chromedp.Run(ctx,
chromedp.Click(`button[name="star"][value="`+deepFile+`"]`, chromedp.ByQuery),
chromedp.WaitVisible(`li[data-key="`+deepFile+`"] button[name="star"]`, chromedp.ByQuery),
// Wait for the star itself to change, not for the button to exist. The
// button is already on screen before the click — only its text changes —
// so a WaitVisible here is satisfied instantly and the assertion below
// races the WebSocket round trip. Every other wait in this test targets
// an element the update creates, which is why only this step flaked.
e2etest.WaitFor(`document.querySelector('li[data-key="`+deepFile+`"] button[name="star"]').textContent.includes('★')`, 10*time.Second),
chromedp.Evaluate(`document.querySelector('li[data-key="`+deepFile+`"] button[name="star"]').textContent.includes('★')`, &starred),
chromedp.Evaluate(`document.querySelector('li[data-key="/internal/store/sql/migrate.go"]').__lvtMark === 'sibling'`, &siblingSurvived),
); err != nil {
Expand Down
Loading