chore(deps): bump js-yaml from 4.3.2 to 5.4.1 - #262
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
This is a major-version dependency upgrade (4.x → 5.x) with stated upstream breaking changes, and correctness depends on runtime behavior that can’t be fully verified from the diff alone.
Pull request overview
Updates the repository’s Node.js dependency graph by bumping the direct js-yaml dependency to the 5.x line, along with the corresponding Yarn lockfile updates, to pick up the latest upstream changes and security-related limits.
Changes:
- Bump
js-yamlinpackage.jsonfrom^4.1.1to^5.4.1. - Update
yarn.lockto add thejs-yaml@^5.4.1resolution while retaining existing 3.x/4.x resolutions required by transitive dependencies.
File summaries
| File | Description |
|---|---|
| package.json | Updates the direct js-yaml dependency range to ^5.4.1. |
| yarn.lock | Adds lock entry for js-yaml@^5.4.1 and adjusts selectors accordingly; keeps older versions for transitive requirements. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.2 to 5.4.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.3.2...5.4.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.4.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
661d15f to
5c8d263
Compare
There was a problem hiding this comment.
🟡 Changes recommended
A remaining Yarn resolution still pins Mocha to js-yaml v4, making the upgrade incomplete relative to the PR’s stated intent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
| "fs-extra": "^11.3.3", | ||
| "handlebars": "^4.7.9", | ||
| "js-yaml": "^4.3.1", | ||
| "js-yaml": "^5.4.1", |
Bumps js-yaml from 4.3.2 to 5.4.1.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
e5a3ba05.4.1 releasede54dea3Hard-limit merge sequence size to 100dfd3a29Cleanup 6a8e05f, #7976a8e05ffix: count empty merge sources against maxTotalMergeKeys (#797)6b4ff5e5.4.0 released3b3625eUpdate changelog4f25a74Fix file name3bd003bExpose new scalar styling APIfbb3e9dRemove regex lookbehind for ES2015 compatibilityd43c185FixflowSkipColonSpaceby forcingquoteFlowKeys