build(deps): upgrade go-ethereum to 1.17.5 and adapt to its api changes - #4043
Open
rickstaa wants to merge 1 commit into
Open
build(deps): upgrade go-ethereum to 1.17.5 and adapt to its api changes#4043rickstaa wants to merge 1 commit into
rickstaa wants to merge 1 commit into
Conversation
github-actions
Bot
added
dependencies
This was referenced Sep 8, 2026
rickstaa
changed the title
rickstaa
force-pushed
the
build/go-ethereum-1.17
branch
from
September 8, 2026 21:51
0e8a962 to
2a2e61f
Compare
go-ethereum 1.17 replaced its log package with slog, removed the plaintext keystore and added SubscribeTransactionReceipts to TransactionReader. livepeer_cli and the eth test stubs are updated. gnark-crypto moves with it since 0.18 does not build against geth 1.13, and google.golang.org/api moves so it compiles against the grpc that geth pulls in.
rickstaa
force-pushed
the
build/go-ethereum-1.17
branch
from
September 9, 2026 05:34
2a2e61f to
7885984
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4043 +/- ##
===================================================
- Coverage 39.88785% 39.84980% -0.03805%
===================================================
Files 174 174
Lines 39413 39413
===================================================
- Hits 15721 15706 -15
- Misses 23692 23707 +15
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
@j0sh, builds, test pass. E2E for transcoding, live-video-to-video and live-runner verified. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades go-ethereum from 1.13.5 to 1.17.5 together with gnark-crypto, which does not build against geth 1.13, and google.golang.org/api, which does not compile against the grpc version geth pulls in. Rebased onto master after the Go 1.27 upgrade.
Code changes are limited to what the new API requires: livepeer_cli now configures the slog based logger, and the eth tests drop the removed plaintext keystore and implement the new receipts subscription on the stub. Build, all test packages, and the eth, pm, livepeer_cli, core and server suites pass locally.
Supersedes Dependabot's #4055. Worth a run against a real network before merge since this covers four minor releases of the client used for signing and sending transactions.