Upgrade to golang 1.27.0 - #4031
Merged
Merged
Conversation
- require Go 1.27.0 and refresh dependency classifications with Go 1.27's go mod tidy formatting - update the primary and MediaMTX Docker builders to Go 1.27.0 - raise the Darwin ARM64 deployment target to macOS 13 since that is what 1.27 requires - replace the pinned golangci-lint call with straight go vet since golangci-lint only invoked go vet - use synctest.Sleep for direct sleep-and-wait sequences in live runner accounting tests - replace google/uuid with the new standard library uuid package - derive serverless trickle URLs with url.URL.Clone - simplify Docker worker and payment stub literals using promoted embedded fields - remove cancellation-function pointer comparisons in pricefeedwatcher tests that would have gotten more unreliable due to compiler changes resulting in different closures having equal function pointers more often
github-actions
Bot
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4031 +/- ##
===================================================
+ Coverage 35.53708% 39.88785% +4.35077%
===================================================
Files 174 174
Lines 45226 39413 -5813
===================================================
- Hits 16072 15721 -351
+ Misses 27880 23692 -4188
+ Partials 1274 0 -1274
... and 170 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
The reflect-based cancel func comparison this replaces could never fail: reflect.Value.Pointer returns a code pointer, and every cancelWatch comes from context.WithCancel, so all of them compared equal regardless of how many loops ran. Each watch loop polls the price feed once per period, so a duplicate loop is observable as a duplicate FetchPriceData call. synctest makes the hour long period instant and the goroutine scheduling deterministic.
rickstaa
approved these changes
Aug 21, 2026
Member
|
@j0sh if you want a stand-alone pr to fix the tests. I added it in https://github.com/livepeer/go-livepeer/pull/4044/commits. I also updated the docs ec64ef0. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
For more details on golang 1.27 see the release notes