This repository was archived by the owner on Aug 13, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
runner: add data_url to route/pipeline and codegen #710
Open
ad-astra-video
wants to merge
3
commits into
main
Choose a base branch
from
av/add-data-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1000,6 +1000,12 @@ components: | |||||||||||||||||||||||||||||||||
| description: URL for publishing events via Trickle protocol for pipeline | ||||||||||||||||||||||||||||||||||
| status and logs. | ||||||||||||||||||||||||||||||||||
| default: '' | ||||||||||||||||||||||||||||||||||
| data_url: | ||||||||||||||||||||||||||||||||||
| type: string | ||||||||||||||||||||||||||||||||||
| title: Data Url | ||||||||||||||||||||||||||||||||||
| description: URL for publishing data via Trickle protocol for pipeline status | ||||||||||||||||||||||||||||||||||
| and logs. | ||||||||||||||||||||||||||||||||||
|
Comment on lines
996
to
+1007
|
||||||||||||||||||||||||||||||||||
| description: URL for publishing events via Trickle protocol for pipeline | |
| status and logs. | |
| default: '' | |
| data_url: | |
| type: string | |
| title: Data Url | |
| description: URL for publishing data via Trickle protocol for pipeline status | |
| and logs. | |
| description: URL for publishing events, such as pipeline status updates and | |
| logs, via the Trickle protocol. | |
| default: '' | |
| data_url: | |
| type: string | |
| title: Data Url | |
| description: URL for publishing processed data or intermediate results via | |
| the Trickle protocol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1158,6 +1158,12 @@ components: | |||||||||||||||||||||||||||||||||
| description: URL for publishing events via Trickle protocol for pipeline | ||||||||||||||||||||||||||||||||||
| status and logs. | ||||||||||||||||||||||||||||||||||
| default: '' | ||||||||||||||||||||||||||||||||||
| data_url: | ||||||||||||||||||||||||||||||||||
| type: string | ||||||||||||||||||||||||||||||||||
| title: Data Url | ||||||||||||||||||||||||||||||||||
| description: URL for publishing data via Trickle protocol for pipeline status | ||||||||||||||||||||||||||||||||||
| and logs. | ||||||||||||||||||||||||||||||||||
|
Comment on lines
1154
to
+1165
|
||||||||||||||||||||||||||||||||||
| description: URL for publishing events via Trickle protocol for pipeline | |
| status and logs. | |
| default: '' | |
| data_url: | |
| type: string | |
| title: Data Url | |
| description: URL for publishing data via Trickle protocol for pipeline status | |
| and logs. | |
| description: URL for publishing event-related information, such as pipeline | |
| status updates and logs, via the Trickle protocol. | |
| default: '' | |
| data_url: | |
| type: string | |
| title: Data Url | |
| description: URL for publishing data outputs generated by the pipeline, such as | |
| processed video frames or analysis results, via the Trickle protocol. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for
data_urlis identical toevents_urlexcept for the word 'data' vs 'events'. This doesn't clearly explain what distinguishes data_url from events_url or what type of data will be published through this URL.