clang-format in CI#116
Conversation
stephen-derosa
left a comment
stephen-derosa
left a comment
There was a problem hiding this comment.
just doc-ing to ensure its tracked, need to update:
- AGENTS.md:
Use clang formatting that aligns with the existing codebase. - README.md:
clang-format: (coming soon) code formatting and style consistency
There was a problem hiding this comment.
do we need to support a windows version of this?
There was a problem hiding this comment.
Right now we caveat in the read me that clang tools are just on Mac/Linux, I think clang-format does work on Windows since it doesn't depend on compile_commands.json, and this check would be a blocker for any Windows developers. What I don't want to do is duplicate/maintain the clang-format.sh script for a niche use case (windows based contributions). I think user on Windows could just run clang-format.exe <path to offending files> and wouldn't need the script (which is more convenient for us).
How do you feel about not duplicating the script and just adding a blurb to the readme saying you're on your own to run it? CI will still flag the offending files
2 participants
No description provided.