-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: preserve adaptive interruption across tool calls #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
db981aa
b161cfc
729860b
6d7d97d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -696,6 +696,7 @@ def _on_overlapping_speech(self, event: OverlappingSpeechEvent) -> None: | |||||||||||||
| overlap_started_at = Timestamp() | ||||||||||||||
| overlap_started_at.FromNanoseconds(int(event.overlap_started_at * 1e9)) | ||||||||||||||
|
|
||||||||||||||
| # TODO(AGT-3180): Forward agent_ended when the remote-session protocol supports it. | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Inconclusive overlap results are now reported to remote sessions as if the user only backchanneled Overlaps that end because the agent stopped talking are now published ( Impact: Remote dashboards/consumers will count these inconclusive overlaps as backchannels, inflating backchannel statistics for turns where the user may actually have been interrupting. Why these events start reaching the remote session only nowBefore this PR, Locally this was compensated for: Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified this against the branch head (217d25f) — the finding is real, and it is newly reachable behavior rather than a pre-existing gap:
Since the proto change lives in livekit/protocol (an
Suggested change
Suppressing the event entirely matches pre-PR remote behavior (these overlaps produced no event at all), so nothing downstream regresses in the meantime, and the TODO keeps the protocol follow-up visible. |
||||||||||||||
| pb = agent_pb.AgentSessionEvent.OverlappingSpeech( | ||||||||||||||
| is_interruption=event.is_interruption, | ||||||||||||||
| detection_delay=event.detection_delay, | ||||||||||||||
|
|
||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.