-
Notifications
You must be signed in to change notification settings - Fork 342
fix: preserve adaptive interruption across tool calls #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosetta-livekit-bot
wants to merge
1
commit into
main
Choose a base branch
from
gals-aseptic-hanks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents': patch | ||
| --- | ||
|
|
||
| Preserve adaptive interruption boundaries when agent playout pauses or enters a tool-call thinking gap. |
44 changes: 44 additions & 0 deletions
44
agents/src/inference/interruption/interruption_stream.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // SPDX-FileCopyrightText: 2026 LiveKit, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import type { InterruptionMetrics } from '../../metrics/base.js'; | ||
| import { MockWebSocket } from './_mock_ws.js'; | ||
| import { AdaptiveInterruptionDetector } from './interruption_detector.js'; | ||
| import { InterruptionStreamBase, InterruptionStreamSentinel } from './interruption_stream.js'; | ||
|
|
||
| vi.mock('ws', async () => { | ||
| const { MockWebSocket } = await import('./_mock_ws.js'); | ||
| return { default: MockWebSocket, WebSocket: MockWebSocket }; | ||
| }); | ||
|
|
||
| describe('InterruptionStreamBase metrics', () => { | ||
| it('does not count agent-ended overlap as a backchannel', async () => { | ||
| MockWebSocket.instances.length = 0; | ||
| const detector = new AdaptiveInterruptionDetector({ | ||
| apiKey: 'test-key', | ||
| apiSecret: 'test-secret', | ||
| baseUrl: 'http://localhost:9999', | ||
| }); | ||
| const stream = new InterruptionStreamBase(detector, {}); | ||
| const metrics: InterruptionMetrics[] = []; | ||
| detector.on('metrics_collected', (event) => metrics.push(event)); | ||
| const reader = stream.stream().getReader(); | ||
|
|
||
| try { | ||
| await vi.waitFor(() => expect(MockWebSocket.instances).toHaveLength(1)); | ||
| MockWebSocket.instances[0]!.simulateOpen(); | ||
| const event = reader.read(); | ||
| await stream.pushFrame(InterruptionStreamSentinel.agentSpeechStarted()); | ||
| await stream.pushFrame(InterruptionStreamSentinel.overlapSpeechStarted(0, Date.now())); | ||
| await stream.pushFrame(InterruptionStreamSentinel.overlapSpeechEnded(Date.now(), true)); | ||
| await event; | ||
|
|
||
| expect(metrics).toHaveLength(1); | ||
| expect(metrics[0]).toMatchObject({ numInterruptions: 0, numBackchannels: 0 }); | ||
| } finally { | ||
| await reader.cancel(); | ||
| await stream.close(); | ||
| } | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pausing the agent's voice now reports a bogus "user talked over the agent" event every time
An overlap is opened and then immediately closed as agent-ended (
onStartOfOverlapSpeechatagents/src/voice/agent_activity.ts:1684-1689followed byonEndOfAgentSpeechatagents/src/voice/agent_activity.ts:1696) whenever agent playout is paused, so listeners receive an extra overlapping-speech notification and a zero-valued measurement for a pause that produced no real judgement.Impact: Applications and dashboards subscribed to overlapping-speech events see spurious entries (and zeroed interruption metrics) each time the agent's voice is paused.
Mechanism: overlap opened right before the boundary that closes it
Before this PR the pause path passed
{ paused: true }, so noagent-speech-endedsentinel was written and the overlap opened atagents/src/voice/agent_activity.ts:1684stayed open across the pause (an event was produced only on a real verdict or user-speech end).Now
onEndOfAgentSpeech(agents/src/voice/audio_recognition.ts:784-831) always closes any open overlap viacloseOverlap(now, undefined, true)and then sendsagent-speech-ended. Since the pause path opens the overlap synchronously one statement earlier, the queued sentinel pair isoverlap-speech-started+overlap-speech-ended(agentEnded: true), and the transform atagents/src/inference/interruption/interruption_stream.ts:274-300enqueues anOverlappingSpeechEventbuilt fromInterruptionCacheEntry.default()(all zeros,isInterruption: false). That event is emitted publicly (this.model.emit('overlapping_speech', chunk)atagents/src/inference/interruption/interruption_stream.ts:331) and forwarded to the session, plus aninterruption_metricsevent withnumInterruptions: 0/numBackchannels: 0.If the intent is that pausing is a plain speech boundary, the overlap open at
agents/src/voice/agent_activity.ts:1683-1689is now redundant and should be dropped (the overlap is re-opened byonStartOfAgentSpeechwhen playout resumes while the user is still speaking,agents/src/voice/audio_recognition.ts:770-775).Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.