(Desktop) Fix livebook stdout closed on non-utf8 bytes - #3201
Merged
Conversation
josevalim
approved these changes
Jul 14, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3200.
The desktop app spawns the Livebook Elixir node and reads stdout. If an invalid UTF-8 byte appears in the stdout, the reader finishes and effectively closes the pipe for writing. Once the pipe is closed, trying to log to stdout crashes the
:userprocess, causing the reported issue. Elixir/Erlang code should not produce a byte like this, however a NIF might print anything.The error can be reproduced by writing invalid byte directly to stdout descriptor:
Once the stdout is closed, it is corrupted as long as the app is running. When a runtime is restarted, any logging triggers the same
:usercrash.