Required fulfillment; vernier support; lime import with no pricings; accessibility improvements; other fixes#926
Merged
Merged
Conversation
(could not figure out how to unit test this code so of course the 'fix' had a bug)
There isn't a reason we can think of to make them optional; instead, admins can create an 'other'-style option requiring an explicit expression of user intent.
- Add aria label to social media links
- Improve OTP input label ("digit 1 of 6")
- Add role=alert to FormError
We assume a member always has eligible pricings available when importing lime trips. However, eligibility changes mean perhaps no pricing is eligible. When this happens, we instead look for all available pricings when the trip was taken. If there is only one service/rate combination (multiple pricings are okay), we can be reasonably confident that is the right pricing to use. If we find no potential pricing, or multiple, we raise an error.
Requires custom startup and middleware since we're not using Rails.
This reverts commit cd9918f25446df673d1f31c20bdc0955ff6837a7.
Profiling SaaS did not give us the level of info we needed to profile live apps. This is a lightweight profiling solution based on sampling profiling with vernier.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
========================================
Coverage 99.82% 99.82%
========================================
Files 748 750 +2
Lines 37010 37226 +216
========================================
+ Hits 36946 37162 +216
Misses 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add endpoint-specific vernier middleware
Add vernier app for controlling live profiling
Profiling SaaS did not give us the level of info we needed
to profile live apps. This is a lightweight profiling solution
based on sampling profiling with vernier.
Revert "Add Scout APM support"
This reverts commit cd9918f25446df673d1f31c20bdc0955ff6837a7.
Add Scout APM support
Requires custom startup and middleware since we're not
using Rails.
Lime trip import handles no pricings
We assume a member always has eligible pricings available
when importing lime trips.
However, eligibility changes mean perhaps no pricing is eligible.
When this happens, we instead look for all available pricings
when the trip was taken. If there is only one service/rate
combination (multiple pricings are okay),
we can be reasonably confident that is the right pricing to use.
If we find no potential pricing, or multiple,
we raise an error.
Accessibility improvements (OTP, social)
Make fulfillment options required
There isn't a reason we can think of to make them optional;
instead, admins can create an 'other'-style option
requiring an explicit expression of user intent.
UTM capture: Use {} for EmptyContent
(could not figure out how to unit test this code
so of course the 'fix' had a bug)
Update barnes as requested by Heroku