Conversation
Collaborator
Author
|
serve request that is erroring below: vllm serve meta-llama/Meta-Llama-3-8B-Instruct |
lisadunlap
reviewed
May 1, 2025
lisadunlap
left a comment
Owner
There was a problem hiding this comment.
looks good! Mostly minor things and making sure we are updating files instead of making new ones
Owner
There was a problem hiding this comment.
how does this differ from the get_differences.py file? If we are modifying that file let's name it the same thing so we don't muddy the repo
Collaborator
Author
There was a problem hiding this comment.
they actually are doing the same thing just checked now, I can change the name of mine nevertheless though
Owner
There was a problem hiding this comment.
can we instead update the existing utils_llm file
os error -- to take a look
ethantsliu
added a commit
that referenced
this pull request
Jul 20, 2026
… mechanism) + self-control + variance - Overcount CONFIRMED on the current matrix (n=4712, compute_overcount.py): Llama-Guard flags 25.4% unsafe vs 7.2% genuine harm = 3.5x overall (6.7x AdvBench). MECHANISM CORRECTED: 79% of Guard's flags are false-positive CLEAN REFUSALS (Guard reacts to prompt topic, not the response); it also misses 25% of genuine harm. NOT driven by refuse-then-leak (which is a separate real phenomenon, 144 cases both judges agree on). RESULTS.md #1 + RELATED_WORK updated to the measured mechanism. - Imitation-specificity CONFIRMED at seed-42 scale (self-SFT control): ministral imitates ITSELF -0.4pt (null, 4/4 ds) vs OTHERS +3.4pt; aya null both ways. Supersedes the pilot-only evidence. RESULTS.md #2. - variance_decomp.py: reproducible source 79% / target 3% / dataset 0.2% decomposition + stats artifact. - Docs reconciled: README + RESULTS.md source-conditioned (was contradictory "target-conditioned"); dissociation table CONFIRMED (9 CLEAN/4 PC_FAILS/1 PC_INVALID/2 deferred); roster-asymmetry rationale (steering N=20 vs imitation N=9, matched core=8); new docs/RESULTS_INDEX.md links the 3 result stores; data/results/safety/README.md rewritten (was a false "scaffold only" placeholder).
ethantsliu
added a commit
that referenced
this pull request
Jul 20, 2026
…match the data The README led with 'imitation causes erosion of safety', but the matrix shows mean erosion of +0.22pt with 245/540 adapters getting safer and only 2 of 9 sources eroding above 1pt. Leading with an effect that small invites the obvious reviewer question. Reframes the thesis to what the evidence supports: imitation transfers identity without transferring safety, and the reported alarm is largely measurement artifact. Under that framing the guard overcount explains the field's alarm, the small source-conditioned erosion is the empirical result, and the steering dissociation is the mechanism. Adds an explicit evidence-strength table (strong / solid-null / thin) and downgrades Finding #2 from CONFIRMED to SUPPORTING (n=1): the self-SFT-vs-cross contrast is meaningful on ministral-8b alone. Also flags that the connecting claim rests on n=1 within the matched core, and that granite-4-h-small's outstanding steering verdict is what would take it to n=2. (cherry picked from commit b1f202dda85627b60a79936f36ac6e19089bf2db)
ethantsliu
added a commit
that referenced
this pull request
Jul 20, 2026
…tioning; fix backwards docstring Realigns the four findings so the framing matches the evidence strength: - Two PILLARS kept prominent: the measurement overcount (#1) and the causal identity/safety separability (#4). Finding 4 restated as a mechanism result ('where safety lives') rather than 'weight-imitation erodes safety', which the near-null erosion does not support. - Erosion finding (#2) restated as a SOLID null: mean +0.2pt, 45% get safer, imitation does not meaningfully erode safety. - Base-conditioning (#3) softened to TENTATIVE: the 79/3/0.2 decomposition partitions a near-noise signal (harm rates quantised to ~0.5pt, no significance test in the single-seed table); 3-seed pilot finds the same pattern with p-values. 'Asymmetric laundering' now framed as a conditional security reading, not a confirmed result. - Imitation-specificity (self vs cross, n=1) demoted to an explicit single-source supporting observation (appendix-bound), removed from the headline findings. Also fixes a real bug: variance_decomp.py's docstring had source/target defined backwards ('source = the model being imitated') and concluded erosion 'tracks WHO you imitate' -- the opposite of the data. Verified against the CSV: source = the base model that is fine-tuned; erosion tracks the base, not the imitated target. Numbers unchanged; only the interpretation was wrong. Fixes cross-doc inconsistency (Finding 2 was 'CONFIRMED' in RESULTS.md vs 'thin' elsewhere) and a broken '#5' cross-reference. (cherry picked from commit 0033ad28bb15cefd727b1f7d74a27697ad79a62c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.