Skip to content

capture snap - #87

Draft
glyvut wants to merge 1 commit into
linuxdeepin:masterfrom
glyvut:master
Draft

capture snap#87
glyvut wants to merge 1 commit into
linuxdeepin:masterfrom
glyvut:master

Conversation

@glyvut

@glyvut glyvut commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Introduce the experimental capture snap protocol for compositor-provided screenshot and recording snap-region hints.

New Features:

  • Add an experimental compositor protocol for tracking cursor-based snap regions during screenshot or recording sessions, including lifecycle, region updates, and busy-session failure events.

Enhancements:

  • Replace the previous capture protocol definition with the capture snap protocol.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glyvut

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Reviewer's Guide

Introduce a new Wayland protocol definition for capture snap hints and wire it into the build, replacing the previous capture protocol XML.

Sequence diagram for treeland_capture_snap_v1 snap session lifecycle

sequenceDiagram
  participant Client
  participant treeland_capture_snap_v1
  participant Compositor

  Client->>treeland_capture_snap_v1: start()
  treeland_capture_snap_v1->>Compositor: start
  alt [no other snap session active]
    Compositor-->>Client: snap_region(x, y, width, height)
    loop [snap target changes]
      Compositor-->>Client: snap_region(x, y, width, height)
    end
    Client->>treeland_capture_snap_v1: stop()
    treeland_capture_snap_v1->>Compositor: stop
    Client->>treeland_capture_snap_v1: destroy()
  else [another snap session active]
    Compositor-->>Client: failed(reason=snap_busy)
    Client->>treeland_capture_snap_v1: destroy()
  end
Loading

File-Level Changes

Change Details Files
Replace the previous treeland capture protocol XML with a new snap-focused protocol and hook it into CMake.
  • Update the CMake XML list to reference the new treeland-capture-snap-unstable-v1.xml instead of the old treeland-capture-unstable-v1.xml
  • Add a new Wayland protocol XML defining treeland_capture_snap_v1, including start/stop requests, snap_region and failed events, and a failure_reason enum
  • Remove the old treeland-capture-unstable-v1.xml protocol file from the repository
CMakeLists.txt
xml/treeland-capture-snap-unstable-v1.xml
xml/treeland-capture-unstable-v1.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-bot

deepin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 0.5.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #88

Comment thread CMakeLists.txt
@glyvut
glyvut force-pushed the master branch 2 times, most recently from e4d0f64 to 37ffb3d Compare August 18, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants