fix(window-button): load icon synchronously#636
Merged
Conversation
1. Override the window button content item with a DCI icon. 2. Disable asynchronous loading for the icon to avoid a blank first frame. 3. Keep the existing palette, state, theme, and source size bindings. Log: Load window button icons synchronously to prevent startup flicker. fix(window-button): 同步加载窗口按钮图标 1. 使用 DCI 图标覆盖窗口按钮的内容项。 2. 关闭图标异步加载,避免启动首帧空白。 3. 保留原有调色板、状态、主题和源尺寸绑定。 Log: 同步加载窗口按钮图标,避免启动时图标闪烁。 PMS: TASK-390989
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSwitches the window button to use an explicit DCI icon content item that is loaded synchronously, eliminating startup flicker while preserving existing appearance-related bindings. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
deepin pr auto review我对这个代码变更进行了审查,以下是我的分析和改进建议:
代码质量:
代码性能:
代码安全:
潜在改进点:
总体而言,这个代码变更是一个合理的改进,通过使用 DTK 的图标组件提升了系统的集成度和一致性。代码结构清晰,性能考虑周到,安全性有保障。 |
18202781743
approved these changes
Jun 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Load window button icons synchronously to prevent startup flicker.
fix(window-button): 同步加载窗口按钮图标
Log: 同步加载窗口按钮图标,避免启动时图标闪烁。
PMS: TASK-390989
Summary by Sourcery
Bug Fixes: