Skip to content

Revert "chore: add airplane mode interface permission declaration" - #604

Open
fly602 wants to merge 1 commit into
linuxdeepin:masterfrom
fly602:master
Open

Revert "chore: add airplane mode interface permission declaration"#604
fly602 wants to merge 1 commit into
linuxdeepin:masterfrom
fly602:master

Conversation

@fly602

@fly602 fly602 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

This reverts commit ad4f89b.

回退 飞行模式安全启动的注册

原因:配合dde-daemon回退安全启动校验的方案。因为该接口的安全校验影响范围较广,涉及到控制中心、快捷键、任务栏插件等。由于项目架构问题,在这些项目上加安全启动很复杂,而且会严重影响这些项目的架构。

后续计划

需重新评估安全方案的整体设计,制定更契合 V25 架构的分阶段实施方案。

Summary by Sourcery

Revert the dcc-network airplane-mode interface permission declaration.

Build:

  • Remove installation of the dcc-network security permission-interface configuration.

Chores:

  • Delete the dcc-network permission-interface declaration as part of reverting the previous permission change.

Summary by Sourcery

Revert the dcc-network airplane-mode permission declaration to roll back the associated secure-startup integration.

Build:

  • Stop installing the dcc-network security permission-interface configuration.

Chores:

  • Remove the dcc-network airplane-mode permission-interface declaration.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fly602, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fully reverts the previously added airplane mode permission interface for the dcc-network plugin, removing its installation and packaging artifacts.

File-Level Changes

Change Details Files
Remove installation of the dcc-network permission interface configuration from the build system.
  • Delete the CMake install rule that copied the org.deepin.dcc-network permission interface JSON into the dde-control-center permission-interfaces directory
  • Keep plugin translation handling intact while removing only the permission interface-related install block
dcc-network/CMakeLists.txt
Remove the airplane mode permission interface JSON and its packaging references.
  • Delete the org.deepin.dcc-network permission interface JSON file from the source tree
  • Update Debian packaging to stop installing or referencing the removed permission interface file in the plugin package
dcc-network/misc/permission-interfaces/org.deepin.dcc-network.json
debian/control
debian/dcc-network-plugin.install

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

…回退飞行模式安全启动的注册

原因:配合 dde-daemon 回退安全启动校验的方案。该接口的安全校验
影响范围较广,涉及控制中心、快捷键、任务栏插件等。由于项目架构
问题,在这些项目上加安全启动很复杂,且会严重影响这些项目的架构。

后续计划

需重新评估安全方案的整体设计,制定更契合 V25 架构的分阶段实施方案。
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码清理了不再需要的D-Bus权限配置和硬依赖,重构逻辑清晰
移除冗余配置和依赖提升了打包灵活性,无安全漏洞

■ 【详细分析】

  • 1.语法逻辑(基本正确)✓

diff 正确移除了 CMakeLists.txt 中的 install 指令、删除了对应的 JSON 配置文件,并同步修改了 debian/control 和 install 文件,语法无误
潜在问题:需确保网络插件代码内部已完全移除对 org.deepin.dde.AirplaneMode1 接口的调用,否则会导致运行时 D-Bus 调用失败
建议:在代码库中全局搜索 AirplaneMode1,确认无残留引用

  • 2.代码质量(符合规范)✓

移除了不再需要的权限配置文件和 dde-daemon 的硬依赖,降低了模块间的耦合度,使得网络插件的安装更加独立
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

移除配置文件和依赖声明对运行时性能无负面影响,反而可能略微减少安装体积
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改为移除权限配置和依赖,未引入新的代码逻辑,不存在安全风险
建议:无

■ 【改进建议代码示例】

// 当前修改已足够,无需额外代码修复
// 建议在提交信息中注明移除 AirplaneMode1 权限的原因,例如:
// "refactor(network): remove unused AirplaneMode1 D-Bus permission and dde-daemon hard dependency"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants