Skip to content

llvm2lcov: use ignorable_error rather than die for unsupported MC/DC entries format #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henry2cox merged 1 commit into from
May 21, 2026
+11 −6
Merged

llvm2lcov: use ignorable_error rather than die for unsupported MC/DC entries format #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions bin/llvm2lcov
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,12 +461,17 @@ sub parse
# 'Executed MC/DC Test Vectors' table.
# However, this is not used for presenting MC/DC data,
# so we ignore this field.
die("unsupported MC/DC entry size $mSize in JSON file version '$json_version'"
)
unless ($json_version > version->parse("3.0.1") &&
$mSize == 11) ||
($json_version == version->parse("3.0.1") &&
$mSize == 10);
if (!( $json_version > version->parse("3.0.1") &&
$mSize == 11)
&&
!( $json_version == version->parse("3.0.1") &&
$mSize == 10)
) {
lcovutil::ignorable_error($lcovutil::ERROR_FORMAT,
"unsupported MC/DC entry size $mSize in JSON file version '$json_version'"
);
last;
}
my ($line, $col, $endLine, $endCol,
$trueCount, $falseCount, $fileId, $expandedId,
$kind, $cov) = @$m;
Expand Down