Skip to content

ocp: sanitize tainted ascii_id_length before memcpy #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Aug 10, 2026
+6 −3
Merged

ocp: sanitize tainted ascii_id_length before memcpy #3786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions plugins/ocp/ocp-telemetry-decode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ int get_statistic_id_ascii_string(int identifier, char *description)
SIZE_OF_DWORD));

memcpy(description, pdescription,
peach_statistic_entry->ascii_id_length + 1);
peach_statistic_entry->ascii_id_length);
description[peach_statistic_entry->ascii_id_length] = '\0';

return 0;
}
Expand Down Expand Up @@ -679,7 +680,8 @@ int get_event_id_ascii_string(int identifier, int debug_event_class, char *descr
(peach_event_entry->ascii_id_offset * SIZE_OF_DWORD));

memcpy(description, pdescription,
peach_event_entry->ascii_id_length + 1);
peach_event_entry->ascii_id_length);
description[peach_event_entry->ascii_id_length] = '\0';
return 0;
}
}
Expand Down Expand Up @@ -717,7 +719,8 @@ int get_vu_event_id_ascii_string(int identifier, int debug_event_class, char *de
(peach_vu_event_entry->ascii_id_offset * SIZE_OF_DWORD));

memcpy(description, pdescription,
peach_vu_event_entry->ascii_id_length + 1);
peach_vu_event_entry->ascii_id_length);
description[peach_vu_event_entry->ascii_id_length] = '\0';
return 0;
}
}
Expand Down
Loading