solidigm: remove logically dead code in parse_tracker_chunk_json - #3785
Merged
igaw merged 1 commit intoAug 10, 2026
Merged
Conversation
entry_info is guaranteed non-NULL at this point because the !entry_info guard above would have continued to the next loop iteration if it were NULL. The ternary expression entry_info ? get_arg_description(entry_info, i) : NULL therefore has a dead branch. Replace it with a direct call to get_arg_description(). Fixes Coverity CID 557386 (DEADCODE). Signed-off-by: Brooke Ellis <Brooke.Ellis@ibm.com>
bellis-ibm
force-pushed
the
fix/coverity-dead-code-tracker
branch
from
August 7, 2026 20:18
063f7e3 to
24d0178
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entry_info is guaranteed non-NULL at this point because the
!entry_info guard above would have continued to the next loop
iteration if it were NULL. The ternary expression
entry_info ? get_arg_description(entry_info, i) : NULL
therefore has a dead branch. Replace it with a direct call to
get_arg_description().
Fixes Coverity CID 557386 (DEADCODE).
Signed-off-by: Brooke Ellis Brooke.Ellis@ibm.com