solidigm-telemetry: check return value of sldm_telemetry_structure_parse - #3781
Open
sahmed-ibm wants to merge 1 commit into
Open
solidigm-telemetry: check return value of sldm_telemetry_structure_parse#3781sahmed-ibm wants to merge 1 commit into
sahmed-ibm wants to merge 1 commit into
Conversation
The return value of sldm_telemetry_structure_parse() was not being checked before proceeding to use the parsed_struct object for NLOG and side trace processing. If parsing fails, the incomplete structure data would lead to invalid results in downstream operations. Check the return value and skip to the next iteration if parsing fails. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of sldm_telemetry_structure_parse() was not being checked before proceeding to use the parsed_struct object for NLOG and side trace processing. If parsing fails, the incomplete structure data would lead to invalid results in downstream operations.
Check the return value and skip to the next iteration if parsing fails.