tree-fabrics: fix null pointer dereference in ctrl_lookups() - #3779
Merged
Conversation
The ctrl_lookups() function calls libnvme_first_host() to get the first host entry, then immediately passes @h to libnvme_get_subsystem() without checking whether the return value is NULL. libnvme_first_host() returns NULL when the host list is empty. Dereferencing a NULL @h inside libnvme_get_subsystem() causes undefined behavior. Add shr_assert(h) after the call to libnvme_first_host() to catch a NULL return and abort early, consistent with the existing check used after libnvme_create_host() in the same file. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ctrl_lookups() function calls libnvme_first_host() to get the first host entry, then immediately passes h to
libnvme_get_subsystem() without checking whether the return value is NULL.
libnvme_first_host() returns NULL when the host list is empty. Dereferencing a NULL h inside libnvme_get_subsystem() causes undefined behavior.
Add shr_assert(h) after the call to libnvme_first_host() to catch a NULL return and abort early, consistent with the existing check used after libnvme_create_host() in the same file.