nvme-print: revert outer loop bound change in json_nvme_fdp_configs() - #3778
Merged
igaw merged 1 commit intoAug 10, 2026
Merged
Conversation
Per NVMe spec section "5.2.12.1.29 Flexible Data Placement (FDP) Configurations (Log Page Identifier 20h)", the @log->n field is a 0-based value. A value of 0 means one configuration, a value of 1 means two configurations, and so on. Therefore the loop must iterate n + 1 times to cover all configurations reported by the device. The earlier change to use i < n was incorrect and is reverted here. The Coverity TAINTED_SCALAR report on this loop bound is a false positive: the loop bound i < n + 1 is correct per spec. Fixes: a7bf8a9 ("nvme-print: fix untrusted loop bounds in json_nvme_fdp_configs()") Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
Och, those 0-based indexes should have been banned in the spec. Thanks for checking after me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per NVMe spec section "5.2.12.1.29 Flexible Data Placement (FDP) Configurations (Log Page Identifier 20h)", the log->n field is a 0-based value. A value of 0 means one configuration, a value of 1 means two configurations, and so on. Therefore the loop must iterate n + 1 times to cover all configurations reported by the device.
The earlier change to use i < n was incorrect and is reverted here. The Coverity TAINTED_SCALAR report on this loop bound is a false positive: the loop bound i < n + 1 is correct per spec.
Fixes: a7bf8a9 ("nvme-print: fix untrusted loop bounds in json_nvme_fdp_configs()")
Partially reverts #3727