Skip to content

libnvme/test: fix use after free in test_nvmf_sanitize_addrs() #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Aug 10, 2026
+25 −23
Merged

libnvme/test: fix use after free in test_nvmf_sanitize_addrs() #3759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions libnvme/test/test-fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,11 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)
params.subsysnqn = "nqn.2024-01.com.example:test";
params.traddr = "192.168.1.10";
params.host_traddr = "storage.example.com";
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c && !strcmp(libnvme_ctrl_get_host_traddr(c),
"storage.example.com");
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created with hostname host_traddr");
if (!c)
return false;
p = !strcmp(libnvme_ctrl_get_host_traddr(c), "storage.example.com");
CHECK(p, "hostname host_traddr stored verbatim at creation");
pass &= p;

Expand All @@ -504,10 +506,10 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)
/* A hostname traddr is rejected the same way. */
params.traddr = "storage.example.com";
params.host_traddr = NULL;
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c != NULL;
CHECK(p, "ctrl created with hostname traddr");
pass &= p;
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created with hostname traddr");
if (!c)
return false;

ret = nvmf_sanitize_addrs(ctx, c);
p = ret == -ENVME_CONNECT_TRADDR;
Expand All @@ -518,10 +520,10 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)

/* An uncompressed IPv6 traddr is canonicalized. */
params.traddr = "2001:0db8:0000:0000:0000:0000:0000:0001";
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c != NULL;
CHECK(p, "ctrl created with uncompressed IPv6 traddr");
pass &= p;
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created with uncompressed IPv6 traddr");
if (!c)
return false;

ret = nvmf_sanitize_addrs(ctx, c);
p = !ret && !strcmp(libnvme_ctrl_get_traddr(c), "2001:db8::1");
Expand All @@ -537,10 +539,10 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)
* call, same as host_iface.
*/
params.traddr = "fe80::1%nonexistent0";
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c != NULL;
CHECK(p, "ctrl created with bad-zone scoped IPv6 traddr");
pass &= p;
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created with bad-zone scoped IPv6 traddr");
if (!c)
return false;

ret = nvmf_sanitize_addrs(ctx, c);
p = !ret && !strcmp(libnvme_ctrl_get_traddr(c), "fe80::1%nonexistent0");
Expand All @@ -553,10 +555,10 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)
/* fc: a WWN traddr is left untouched (not an IP transport). */
params.transport = "fc";
params.traddr = "nn-0x1:pn-0x2";
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c != NULL;
CHECK(p, "ctrl created with fc WWN traddr");
pass &= p;
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created with fc WWN traddr");
if (!c)
return false;

ret = nvmf_sanitize_addrs(ctx, c);
p = !ret && !strcmp(libnvme_ctrl_get_traddr(c), "nn-0x1:pn-0x2");
Expand All @@ -569,10 +571,10 @@ static bool test_nvmf_sanitize_addrs(struct libnvme_global_ctx *ctx)
/* loop: no traddr at all -- nothing to sanitize. */
params.transport = "loop";
params.traddr = NULL;
ret = libnvme_create_ctrl(ctx, &params, &c);
p = !ret && c != NULL;
CHECK(p, "ctrl created for loop transport");
pass &= p;
libnvme_create_ctrl(ctx, &params, &c);
CHECK(c, "ctrl created for loop transport");
if (!c)
return false;

ret = nvmf_sanitize_addrs(ctx, c);
p = ret == 0;
Expand Down
Loading