chore(ci): pin build job to rust 1.96.1#302
Merged
Merged
Conversation
The blocking build job installs no toolchain and runs against whatever stable the ubuntu-latest runner image happens to preinstall. A runner image bump therefore lands a new compiler and a new clippy on master and on every open pull request at once, with no change on our side. Clippy 1.97 already flags thirteen pre-existing useless_borrows_in_formatting sites, so the next image refresh would turn CI red with nothing to point at. This pins the job to 1.96.1, the newest stable whose clippy is clean on the current tree, and installs it with the clippy and rustfmt components the job uses. CI becomes deterministic, and moving to a newer toolchain becomes a deliberate, reviewable change rather than something that happens to us. The MSRV job is untouched: it keeps its explicit cargo +1.88, which still overrides the default. Uninstall the toolchain the image ships with once we have switched off it. The job builds the workspace three times over and then runs a publish dry run, which leaves little disk headroom on the runner, and keeping a second toolchain around is enough to run it out of space.
AlfioEmanueleFresta
force-pushed
the
chore/pin-ci-toolchain
branch
from
July 14, 2026 19:09
5cc98cf to
9dcdcd9
Compare
AlfioEmanueleFresta
added a commit
that referenced
this pull request
Jul 14, 2026
Stacked on #302. Now the toolchain is pinned we can move it on purpose. Bump to 1.97.0 and fix the 13 clippy warnings it brings. They are all the same one: a redundant & in a println! or write! argument. Formatting takes its arguments by reference anyway, so nothing changes at runtime. Pinning keeps CI predictable, but on its own it hides drift. This adds a latest stable job running the same checks as the pinned build job. It runs on master and weekly, never on pull requests, so it warns us early without putting a red X on everyone's PR. It also deletes rust-clippy.yml, which has never worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our build job doesn't install a toolchain, so it runs on whatever Rust the runner image happens to ship. Clippy is gated with -D warnings, so the day that image moves to a newer compiler, master and every open PR go red at once.
Pin the job to 1.96.1, which is green today. CI config only, no code changes.