Repository navigation
fix: report file paths passed to threads option - #215
Merged
Merged
Conversation
Require a thread value and report paths before showing no-input help. Cover the requested CLI forms and update usage docs.
Cover two file paths after -t and extensionless file names. Keep the existing invalid thread message and add file path guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
-tand--threads.automode when the option is absent.Why
Commander consumes the token after
-tas an option value.The command
lint-md -t a.mdpreviously lost its only file argument.The CLI now reports that path and exits with an error.
Verification
npm test -- --runInBand: 28 suites and 270 tests passed.npm run lint: passed.npm run test:package: passed.node lib/src/lint-md.js -t a.md: exits 1 and namesa.md.node lib/src/lint-md.js -t a.md b.md: exits 1 and namesa.md.node lib/src/lint-md.js -t README: exits 1 and namesREADME.node lib/src/lint-md.js -t 0 a.md: exits 1 and reports an invalid thread count.No logs or user data are included.
Closes #214