Repository navigation
chore(package): override load-nyc-config to js-yaml 4 - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
js-yamloverride with a targeted override for@istanbuljs/load-nyc-config.js-yaml@4.3.2andargparse@2.0.1.sprintf-jsfrom the dependency tree.Before:
After:
Why
npm auditreported 20 moderate vulnerabilities.All 20 came from
sprintf-js@1.0.3(GHSA-hp3w-g68c-fv3c).sprintf-jshas no fixed release: the advisory covers<=1.1.3, and1.1.3is the latest version.js-yaml@4depends onargparse@2, which does not usesprintf-js.@istanbuljs/load-nyc-configonly callsjs-yaml.load()for.ymland.yamlfiles.load()exists in v4.This chain is dev-only.
npm audit --omit=devwas already 0, and the published package does not include it.Verification
npm auditreports 0 vulnerabilities.npm audit --omit=devreports 0 vulnerabilities.npm ls sprintf-jsis empty.npm testpasses: 27 suites and 238 tests.npm run lintpasses.npm run test:packagepasses.js-yamlCLI runs without deprecation warnings.Closes #203.