chore(chart-deps): update otel-operator to version 0.120.1

[svcAPLBot]

This PR updates the dependency opentelemetry-operator to version 0.120.1.

[Copilot]

Pull request overview

This PR updates the vendored opentelemetry-operator Helm chart dependency to 0.120.1, aligning chart metadata, CRDs, RBAC, and Helm test hooks with the newer upstream release.

Changes:

• Bump the otel-operator chart dependency/version to 0.120.1 and update related app metadata to 0.156.0.
• Update CRDs and RBAC rules to match the newer operator/chart expectations.
• Improve Helm test pods (naming + retry loops) and adjust cert-manager service DNS target.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
charts/otel-operator/values.yaml	Updates default collector image tag to 0.156.0.
charts/otel-operator/values.schema.json	Adds a new feature-gate schema property for operator.collector.usedefaulttelemetryshape.
charts/otel-operator/templates/tests/test-service-connection.yaml	Renames test pods and adds retry loops for service reachability checks.
charts/otel-operator/templates/tests/test-certmanager-connection.yaml	Updates cert-manager service DNS and adds retry loop for reachability checks.
charts/otel-operator/templates/clusterrole.yaml	Expands RBAC (CSV access + instrumentations/status).
charts/otel-operator/crds/crd-opentelemetrycollector.yaml	Updates collector CRD schema (adds status fields like conditions/observedGeneration).
charts/otel-operator/crds/crd-opentelemetry.io_opampbridges.yaml	Updates OpAMPBridge CRD schema (adds tls fields).
charts/otel-operator/Chart.yaml	Bumps chart version to 0.120.1 and appVersion to 0.156.0.
chart/chart-index/Chart.yaml	Updates the otel-operator dependency version to 0.120.1.
apps.yaml	Updates reported OpenTelemetry Operator appVersion to 0.156.0.

Suppressed comments (1)

charts/otel-operator/templates/tests/test-service-connection.yaml:91

• Same issue as the metrics test: wget without -O will try to write files as a non-root user, and exact-string comparison is brittle. Discard the body and match on the status substring instead.

            wget_output=$(wget -q "$WEBHOOK_SERVICE_CLUSTERIP:$WEBHOOK_SERVICE_PORT" 2>&1 || true)
            if [ "$wget_output" = "wget: server returned error: HTTP/1.0 400 Bad Request" ]; then
              exit 0
            fi

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Suppressed comments (4)

charts/otel-operator/templates/tests/test-service-connection.yaml:31

• The Helm test checks for an exact wget stderr string (including HTTP/1.0) to decide success. This is brittle across wget/server versions (HTTP/1.1 vs 1.0, different wording) and can cause flaky failures even when the service is reachable.

          i=0
          while [ "$i" -lt 30 ]; do
            wget_output=$(wget -q "$MANAGER_METRICS_SERVICE_CLUSTERIP:$MANAGER_METRICS_SERVICE_PORT" 2>&1 || true)
            if [ "$wget_output" = "wget: server returned error: HTTP/1.0 400 Bad Request" ]; then
              exit 0

charts/otel-operator/templates/tests/test-service-connection.yaml:90

• Same issue as the metrics test: success depends on an exact wget error string (including HTTP/1.0). This makes the webhook Helm test fragile and prone to false negatives.

          i=0
          while [ "$i" -lt 30 ]; do
            wget_output=$(wget -q "$WEBHOOK_SERVICE_CLUSTERIP:$WEBHOOK_SERVICE_PORT" 2>&1 || true)
            if [ "$wget_output" = "wget: server returned error: HTTP/1.0 400 Bad Request" ]; then
              exit 0

charts/otel-operator/templates/tests/test-certmanager-connection.yaml:30

• This Helm test uses an exact-match comparison against a specific wget error string (HTTP/1.0 400). That is brittle across wget/server versions and can lead to flaky failures. Also, the env var name suggests an IP but the value is a DNS name; renaming avoids confusion while touching this block.

      env:
        - name: CERT_MANAGER_CLUSTERIP
          value: "cert-manager-webhook.cert-manager"
        - name: CERT_MANAGER_PORT
          value: "443"
      command:
        - sh
        - -c
        # The following shell script tests if the cert-manager service is up. If the service is up, when we try
        # to wget its exposed port, we will get an HTTP error 400.
        - |
          i=0
          while [ "$i" -lt 30 ]; do
            wget_output=$(wget -q "$CERT_MANAGER_CLUSTERIP:$CERT_MANAGER_PORT" 2>&1 || true)
            if [ "$wget_output" = "wget: server returned error: HTTP/1.0 400 Bad Request" ]; then

charts/otel-operator/templates/clusterrole.yaml:218

• This adds unconditional patch/update permissions on the cluster-scoped OLM resource operators.coreos.com/clusterserviceversions. If this chart is typically installed outside OLM, consider making these elevated permissions opt-in (or at least documenting why they’re required) to keep the default ClusterRole least-privilege.

  - apiGroups:
      - operators.coreos.com
    resources:
      - clusterserviceversions
    verbs:
      - get
      - list
      - patch
      - update
      - watch

[merll]

#3495