chore(chart-deps): update harbor to version 1.19.2 - #3490
Draft
svcAPLBot wants to merge 6 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the bundled Harbor Helm chart/dependency to 1.19.2 (Harbor appVersion 2.15.2) and aligns related defaults/metadata across the repo.
Changes:
- Bump Harbor chart version to
1.19.2and Harbor appVersion to2.15.2. - Update Harbor component image tags to
v2.15.2, including switching the internal Redis image tovalkey-photon. - Update the chart-index dependency entry to reference Harbor
1.19.2.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/harbor/values.yaml | Updates Harbor component image tags to v2.15.2 and switches internal Redis image to valkey-photon. |
| charts/harbor/README.md | Updates the documented default repository for the internal Redis/Valkey image. |
| charts/harbor/Chart.yaml | Bumps Harbor chart version to 1.19.2 and appVersion to 2.15.2. |
| chart/chart-index/Chart.yaml | Updates the Harbor dependency version to 1.19.2. |
| apps.yaml | Updates Harbor appVersion metadata to 2.15.2. |
Suppressed comments (1)
apps.yaml:83
appsInfo.harbor.appVersionwas bumped to 2.15.2, but the Harbor documentation link still points to the very old 2.6.0 docs, which is likely misleading for users looking up version-specific behavior/configuration. Update the related link to a 2.15.x doc set (or a non-versioned /docs/ landing page) so it aligns with the new appVersion.
appVersion: 2.15.2
repo: https://github.com/goharbor/harbor
maintainers: Project Harbor
relatedLinks:
- https://goharbor.io/docs/2.6.0/
Comment on lines
+352
to
353
| | `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` | | ||
| | `redis.internal.image.tag` | Tag for redis image | `dev` | |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
charts/harbor/README.md:352
- This row now defaults to a Valkey image, but the description still says “redis image”. Update the description to reflect Valkey (Redis-compatible) to avoid confusion.
| `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` |
apps.yaml:83
apps.yamlnow declares HarborappVersion: 2.15.2, but the related documentation link is still pinned to2.6.0, which is inconsistent/misleading. Update the docs link to the matching 2.15 docs series.
appVersion: 2.15.2
repo: https://github.com/goharbor/harbor
maintainers: Project Harbor
relatedLinks:
- https://goharbor.io/docs/2.6.0/
charts/harbor/values.yaml:1140
- Harbor Redis internal image has been switched to
valkey-photon, but the platform override template still points toredis-photonwhenotomi.linodeLkeImageRepositoryis set. That will likely produce an invalid image (tag v2.15.2 on the old repo) or at least diverge from the chart defaults after this bump. Updatevalues/harbor/harbor.gotmplaccordingly so mirrored installs pull the same Valkey image as the upstream chart.
image:
repository: docker.io/goharbor/valkey-photon
tag: v2.15.2
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
charts/harbor/README.md:352
- The default for
redis.internal.image.repositorywas switched togoharbor/valkey-photon, but the description still says "Repository for redis image", which is misleading now that the image is Valkey (Redis-compatible). Consider updating the wording to match the new default to avoid confusion for chart users.
| **Redis** | | |
| `redis.type` | If external redis is used, set it to `external` | `internal` |
| `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
charts/harbor/README.md:353
- The README defaults for the internal Redis/Valkey image are now inconsistent with
values.yaml: the repository was updated togoharbor/valkey-photon, but the description and default tag still refer to Redis anddev. This can mislead users about which image/tag is actually deployed by default.
| `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` |
| `redis.internal.image.tag` | Tag for redis image | `dev` |
apps.yaml:83
apps.yamlnow reports HarborappVersion: 2.15.2, but the first related documentation link still points to/docs/2.6.0/, which is a different major/minor series. This should be updated to the 2.15 documentation to match the upgraded Harbor version.
appVersion: 2.15.2
repo: https://github.com/goharbor/harbor
maintainers: Project Harbor
relatedLinks:
- https://goharbor.io/docs/2.6.0/
charts/harbor/values.yaml:1140
- In Harbor 2.15.2, the bundled Redis component is now Valkey (
valkey-photon). However, the platform values template still overrides the mirrored image repository to.../goharbor/redis-photonwhenotomi.linodeLkeImageRepositoryis set (seevalues/harbor/harbor.gotmpl:173-179). That will cause LKE-mirror installs to pull the old redis image despite the chart defaults being updated here.
type: internal
internal:
image:
repository: docker.io/goharbor/valkey-photon
tag: v2.15.2
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
charts/harbor/README.md:352
- This row still describes the repository as a "redis" image, but the default has been updated to
goharbor/valkey-photon. Adjust the wording to avoid confusion (Valkey is a Redis-compatible replacement).
| `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` |
apps.yaml:83
appsInfo.harbor.relatedLinksstill points to Harbor docs for v2.6.0, which is inconsistent with the bumpedappVersion: 2.15.2and can mislead users. Update the link to the matching Harbor docs version (or to a stable "latest" docs URL if that’s the project convention).
appVersion: 2.15.2
repo: https://github.com/goharbor/harbor
maintainers: Project Harbor
relatedLinks:
- https://goharbor.io/docs/2.6.0/
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
charts/harbor/README.md:353
- The README table still lists
redis.internal.image.tagdefault asdev, butcharts/harbor/values.yamlsets the default tag tov2.15.2. This makes the documentation incorrect for the updated chart version.
| `redis.internal.image.repository` | Repository for redis image | `goharbor/valkey-photon` |
| `redis.internal.image.tag` | Tag for redis image | `dev` |
apps.yaml:83
appsInfo.harbor.appVersionwas updated to2.15.2, but the related documentation link still points tohttps://goharbor.io/docs/2.6.0/, which is very likely outdated/mismatched for the new Harbor version.
appVersion: 2.15.2
repo: https://github.com/goharbor/harbor
maintainers: Project Harbor
relatedLinks:
- https://goharbor.io/docs/2.6.0/
charts/harbor/values.yaml:1140
redis.internal.image.repositorywas switched todocker.io/goharbor/valkey-photon, but the platform values template still hard-codes.../docker/goharbor/redis-photonwhenotomi.linodeLkeImageRepositoryis set (seevalues/harbor/harbor.gotmpl:173-179). With a custom mirror configured, Harbor will continue to pull the old redis image repo and may fail or run an unintended component.
internal:
image:
repository: docker.io/goharbor/valkey-photon
tag: v2.15.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency harbor to version 1.19.2.