chore(chart-deps): update gitea to version 12.7.0 - #3451
Draft
svcAPLBot wants to merge 24 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the embedded Gitea Helm chart to 12.7.0 (Gitea 1.27.0) and brings in the upstream chart’s newly added Gateway API support, updating templates, defaults, and documentation accordingly.
Changes:
- Bump Gitea chart version to
12.7.0and application version to1.27.0(and update the chart index + app catalog metadata). - Add optional Gateway API resources (HTTPRoute/TCPRoute/BackendTLSPolicy + NGINX ClientSettingsPolicy) and new
gatewayAPI.*values. - Refactor service naming references to use new helper includes for consistency.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/gitea/values.yaml | Adds gatewayAPI configuration block and minor values formatting normalization. |
| charts/gitea/templates/tests/test-http-connection.yaml | Updates test to use the HTTP service-name helper include. |
| charts/gitea/templates/gitea/tcpRoute.yaml | New TCPRoute template gated by gatewayAPI values. |
| charts/gitea/templates/gitea/sshService.yaml | Uses centralized SSH service name helper and metadata ordering tweaks. |
| charts/gitea/templates/gitea/route.yaml | Switches Route backend service name to centralized helper. |
| charts/gitea/templates/gitea/ingress.yaml | Switches Ingress backend service name to centralized helper. |
| charts/gitea/templates/gitea/httpService.yaml | Uses centralized HTTP service name helper and metadata ordering tweaks. |
| charts/gitea/templates/gitea/httpRoute.yaml | New HTTPRoute template gated by gatewayAPI values. |
| charts/gitea/templates/gitea/clientSettingsPolicy.yaml | New NGINX Gateway Fabric ClientSettingsPolicy template (optional). |
| charts/gitea/templates/gitea/backendTLSPolicy.yaml | New BackendTLSPolicy template (optional). |
| charts/gitea/templates/gitea/_tcpRoutes.tpl | New helper definitions for TCPRoute enablement/labels/annotations. |
| charts/gitea/templates/gitea/_services.tpl | New helper definitions for HTTP/SSH Service names. |
| charts/gitea/templates/gitea/_httpRoutes.tpl | New helper definitions for HTTPRoute enablement/labels/annotations. |
| charts/gitea/templates/gitea/_clientSettingsPolicies.tpl | New helper definitions for ClientSettingsPolicy enablement/labels/annotations. |
| charts/gitea/templates/gitea/_backendTLSPolicies.tpl | New helper definitions for BackendTLSPolicy enablement/labels/annotations. |
| charts/gitea/templates/_helpers.tpl | Extends public hostname/protocol resolution to consider Gateway API HTTPRoute hostnames and TLS termination. |
| charts/gitea/README.md | Adds Gateway API docs section and parameter table entries. |
| charts/gitea/docs/gateway-api.md | New Gateway API guide for the chart. |
| charts/gitea/Chart.yaml | Version bumps plus updated ArtifactHub changelog entries. |
| charts/gitea/.github/copilot-instructions.md | Adds chart-scoped Copilot guidance for contributors. |
| chart/chart-index/Chart.yaml | Updates chart dependency reference to gitea 12.7.0. |
| apps.yaml | Updates catalog metadata appVersion to 1.27.0. |
Comment on lines
+30
to
+32
| gatewayAPI: | ||
| core: | ||
| httpRoute: |
Comment on lines
2
to
+4
| artifacthub.io/changes: | | ||
| - kind: added | ||
| description: add Gateway API support (#1073) |
|
|
||
| #### Gateway API | ||
|
|
||
| The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`). |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
charts/gitea/README.md:318
- README Gateway API section claims the chart optionally renders a
Gateway, butdocs/gateway-api.mdstates the chart does not render aGatewayresource (and the templates added in this PR only render HTTPRoute/TCPRoute/BackendTLSPolicy/ClientSettingsPolicy). This is misleading for users configuring exposure via Gateway API.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
charts/gitea/README.md:319
- This section says the chart optionally renders a
Gateway, but docs/gateway-api.md explicitly states the chart does not render a Gateway resource. This is contradictory and can mislead users configuring Gateway API.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
See [docs/gateway-api.md](docs/gateway-api.md) for the full guide, including how routes interact with `ROOT_URL`/`DOMAIN` resolution and recommended topologies.
charts/gitea/docs/gateway-api.md:32
- The "Common topology" example enables HTTPRoute/TCPRoute but omits
gatewayAPI.enabled: true. With the current templates, routes/policies are gated bygatewayAPI.enabled, so this example will not render anything as shown.
gatewayAPI:
core:
httpRoute:
charts/gitea/Chart.yaml:8
- The PR description says this change is only updating the gitea dependency to 12.7.0, but this chart update also introduces Gateway API support (and updates appVersion, docs, and templates). Please update the PR description/title to reflect the broader scope, or split unrelated changes if that was not intended.
annotations:
artifacthub.io/changes: |
- kind: added
description: add Gateway API support (#1073)
- kind: changed
description: update alpine/helm docker tag to v3.21.3 (#1096)
- kind: changed
description: update to 1.27.0 (#1095)
Comment on lines
+1
to
+4
| {{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}} | ||
| {{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }} | ||
| {{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/gitea/README.md:319
- README says the chart can render a
Gateway, but the chart docs explicitly state it does not render a Gateway resource and there is nokind: Gatewaytemplate. This sentence should list the actual resources rendered (includingClientSettingsPolicyfor NGINX Gateway Fabric) and omitGateway.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
See [docs/gateway-api.md](docs/gateway-api.md) for the full guide, including how routes interact with `ROOT_URL`/`DOMAIN` resolution and recommended topologies.
charts/gitea/templates/gitea/backendTLSPolicy.yaml:2
- Using
keysfor the requiredgatewayAPI.core.backendTLSPolicy.validationcheck can error if the user setsvalidation:to null. Preferempty(used elsewhere in this chart) so both null and empty maps are handled safely.
{{- if eq (include "gitea.backendTLSPolicy.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
{{- end }}
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:2
- Using
keysfor the requiredgatewayAPI.nginx.clientSettingsPolicies.bodycheck will error if the user setsbody:to null (YAMLnull). Usingemptyis both safer for null and consistent with other required-value validation in this chart (e.g.gpg-secret.yaml).
{{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
{{- end }}
charts/gitea/.github/copilot-instructions.md:18
- This chart directory does not contain a
Makefile, so themake readme/make unittests-*commands documented here will fail. Either add the missing build/test harness or adjust these instructions to match what’s actually available in this repo.
```bash
make readme # Regenerate README.md parameter table + lint
make unittests-helm # Run Helm unit tests (helm-unittest plugin required)
make unittests-bash # Run bash/bats script tests (requires git submodule init)
make unittests # Both of the above
charts/gitea/.github/copilot-instructions.md:50
- This repository does not include an
unittests/helm/directory or a.yamllintconfig undercharts/gitea/, so this section is currently inaccurate. Update it to reflect the repo’s actual test/lint setup, or make it explicitly conditional on those files existing.
- Helm unit tests live in `unittests/helm/` mirroring the template structure.
- Test files are YAML using the [helm-unittest](https://github.com/helm-unittest/helm-unittest) format.
- Each test must set all required values explicitly — do not rely on cross-test state.
- The `values.yaml` file must pass `yamllint`. The configuration is in `.yamllint`. Use `make yamllint` to run the linter.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (6)
charts/gitea/README.md:318
- This sentence says the chart optionally renders a
Gateway, but the new Gateway API guide explicitly states the chart does not render aGatewayresource. This is confusing for users and should be corrected to list only the resources the chart actually renders.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
charts/gitea/.github/copilot-instructions.md:17
- This guidance depends on
maketargets that are not present in this repository, so it will mislead contributors. Adjust these sentences to match the replacement commands (e.g., helm lint/template) or the repo's actual CI workflow.
Always run `make readme` after changing `values.yaml` `@param` annotations.
Always run `make unittests-helm` after changing templates or unit tests.
charts/gitea/docs/gateway-api.md:258
- The hostname resolution order implies
httpRoute.hostnames[0]is used whenevergatewayAPI.core.httpRoute.enabledis true, but the chart logic only uses an HTTPRoute hostname when thehostnameslist is non-empty. The docs should match that behavior (or document that hostnames must be set if you want them to drive ROOT_URL/DOMAIN).
1. `route.host` (when `route.enabled`)
2. `httpRoute.hostnames[0]` (when `gatewayAPI.core.httpRoute.enabled`)
3. First `ingress.hosts[0].host`
charts/gitea/templates/gitea/backendTLSPolicy.yaml:3
- For consistency with the rest of the chart (which uses
emptychecks alongsidefail), preferemptyhere instead ofnot (keys ...). This also avoids surprising behavior ifvalidationis set to a non-map value.
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:3
- The chart already uses
emptyfor required/emptiness checks (e.g. templates/gitea/gpg-secret.yaml) and it handles empty/nil values cleanly. Usingnot (keys ...)here is less idiomatic and can behave unexpectedly if the value is not a map. Preferemptyfor consistency and robustness.
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
charts/gitea/.github/copilot-instructions.md:13
- These instructions reference
maketargets, but this repository does not include a Makefile under charts/gitea (or at the repo root), so these commands will fail for contributors. Update the guidance to commands that exist in this repo, or remove the Makefile-specific section.
This issue also appears on line 16 of the same file.
```bash
make readme # Regenerate README.md parameter table + lint
make unittests-helm # Run Helm unit tests (helm-unittest plugin required)
make unittests-bash # Run bash/bats script tests (requires git submodule init)
make unittests # Both of the above
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/gitea/Chart.yaml:4
- The PR title/description says this is only a Gitea version bump, but the diff also adds Gateway API support (new templates/values/docs). Consider updating the PR description/title to reflect the functional change, or splitting the Gateway API feature into a separate PR if the intent is a pure dependency update.
- kind: added
description: add Gateway API support (#1073)
charts/gitea/templates/gitea/_httpRoutes.tpl:27
{{- with ... }}trims the newline afterinclude "gitea.labels", which can concatenate YAML fragments and produce invalidlabels:output when extra labels are set. Use{{ with ... }}(no left-trim) to preserve the newline.
{{- with .Values.gatewayAPI.core.httpRoute.labels }}
charts/gitea/templates/gitea/_tcpRoutes.tpl:27
{{- with ... }}trims the newline afterinclude "gitea.labels", which can concatenate YAML fragments and produce invalidlabels:output when extra labels are set. Use{{ with ... }}(no left-trim) to preserve the newline.
{{- with .Values.gatewayAPI.core.tcpRoute.labels }}
charts/gitea/templates/gitea/_backendTLSPolicies.tpl:27
{{- with ... }}trims the newline afterinclude "gitea.labels", which can concatenate YAML fragments and produce invalidlabels:output when extra labels are set. Use{{ with ... }}(no left-trim) to preserve the newline.
{{- with .Values.gatewayAPI.core.backendTLSPolicy.labels }}
charts/gitea/templates/gitea/_clientSettingsPolicies.tpl:27
{{- with ... }}trims the newline afterinclude "gitea.labels", which can concatenate YAML fragments and produce invalidlabels:output when extra labels are set. Use{{ with ... }}(no left-trim) to preserve the newline.
{{- with .Values.gatewayAPI.nginx.clientSettingsPolicies.labels }}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/gitea/README.md:318
- This sentence says the chart can optionally render a
Gateway, butdocs/gateway-api.mdexplicitly states the chart does not render aGateway(it expects a pre-existing one). This is misleading for users configuring exposure.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
charts/gitea/docs/gateway-api.md:31
- The example enables
gatewayAPI.core.httpRoute.enabled/tcpRoute.enabledbut omitsgatewayAPI.enabled: true. With the chart logic (include "gitea.httpRoute.enabled"/tcpRoute.enabled), this configuration will render no Gateway API resources.
gatewayAPI:
core:
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:4
keyswill throw a template error if the value isnull/unset (e.g. if a user setsgatewayAPI.nginx.clientSettingsPolicies.body: null). Useemptyinstead so this fails with the intended message for bothniland empty maps.
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
{{- end }}
charts/gitea/templates/gitea/backendTLSPolicy.yaml:4
keyswill throw a template error if the value isnull/unset (e.g.gatewayAPI.core.backendTLSPolicy.validation: null). Useemptyso the chart reliably emits the intendedfailmessage for bothniland empty maps.
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
{{- end }}
charts/gitea/docs/gateway-api.md:257
- This resolution-order bullet should match the actual condition used by the templates/helpers: it requires
gatewayAPI.enabledandgatewayAPI.core.httpRoute.enabled(not just the latter).
2. `httpRoute.hostnames[0]` (when `gatewayAPI.core.httpRoute.enabled`)
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (4)
charts/gitea/README.md:319
- README says the chart can render an optional
Gateway, but the Gateway API guide and the templates in this chart do not render aGatewayresource. This is misleading for users configuring Gateway API exposure.
#### Gateway API
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
See [docs/gateway-api.md](docs/gateway-api.md) for the full guide, including how routes interact with `ROOT_URL`/`DOMAIN` resolution and recommended topologies.
charts/gitea/Chart.yaml:8
- The PR title/description say this is only a version bump to 12.7.0, but the chart changes also introduce Gateway API support (new values, templates, and docs). Please update the PR description/release notes to reflect the additional user-facing feature and any upgrade considerations.
annotations:
artifacthub.io/changes: |
- kind: added
description: add Gateway API support (#1073)
- kind: changed
description: update alpine/helm docker tag to v3.21.3 (#1096)
- kind: changed
description: update to 1.27.0 (#1095)
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:5
- Two issues in the ClientSettingsPolicy template validation: (1) using
keyscan throw a type error when the value isnil/non-map (e.g. user setsbody: null), and (2) whentargetRefis left empty the template defaults to targeting the chart's HTTPRoute, but it does not validate that the HTTPRoute is enabled—so users can render a policy that points at a non-existent HTTPRoute.
{{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
{{- end }}
---
charts/gitea/templates/gitea/backendTLSPolicy.yaml:4
- Using
keysfor required-value validation can error if the value isnil/non-map (e.g., user setsgatewayAPI.core.backendTLSPolicy.validation: null). This can produce a type error instead of the intended fail-fast message. The chart already usesemptyfor similar validation elsewhere (e.g. gpg-secret.yaml).
{{- if eq (include "gitea.backendTLSPolicy.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
{{- end }}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (10)
charts/gitea/templates/gitea/_services.tpl:11
- The service name helper includes a trailing newline (because the output line ends before
end), which can inject a line break into places where the helper is used inside quoted strings. Trim whitespace in the helper output to ensure it always renders as a single token.
{{- define "gitea.service.ssh.name" -}}
{{ include "gitea.fullname" . }}-ssh
{{- end }}
charts/gitea/Chart.yaml:4
- The PR description says this change only updates the gitea chart dependency version, but this update also adds new Gateway API functionality and documentation (see ArtifactHub change note). Please update the PR description to reflect the additional user-facing feature change so reviewers/operators can assess impact appropriately.
annotations:
artifacthub.io/changes: |
- kind: added
description: add Gateway API support (#1073)
charts/gitea/README.md:318
- README says the chart can render an optional
Gateway, but the Gateway API guide explicitly states the chart does not render aGatewayresource. This is contradictory and may mislead users configuring Gateway API exposure.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
charts/gitea/docs/gateway-api.md:32
- The chart requires
gatewayAPI.enabled: truefor any Gateway API resources to render, but this primary example omits it. Copy/pasting this snippet will not enable the HTTPRoute/TCPRoute templates.
gatewayAPI:
core:
httpRoute:
charts/gitea/docs/gateway-api.md:181
- This example omits
gatewayAPI.enabled: true, so BackendTLSPolicy will not render even thoughbackendTLSPolicy.enabledis true. Add the top-level enable flag to avoid a confusing no-op configuration.
gatewayAPI:
core:
backendTLSPolicy:
charts/gitea/templates/gitea/_services.tpl:7
- The service name helper includes a trailing newline (because the output line ends before
end), which can inject a line break into places where the helper is used inside quoted strings (e.g. the Helm test args), producing invalid YAML or an incorrect hostname.
This issue also appears on line 9 of the same file.
{{- define "gitea.service.http.name" -}}
{{ include "gitea.fullname" . }}-http
{{- end }}
charts/gitea/templates/gitea/backendTLSPolicy.yaml:4
- Using
keysfor required-value validation will throw a template type error if the user sets this value tonull(instead of producing the intendedfailmessage). Usingemptykeeps the validation nil-safe and preserves the clearer error message.
{{- if eq (include "gitea.backendTLSPolicy.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
{{- end }}
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:4
- Using
keysfor required-value validation will throw a template type error if the user sets this value tonull(instead of producing the intendedfailmessage). Usingemptykeeps the validation nil-safe and preserves the clearer error message.
{{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
{{- end }}
charts/gitea/docs/gateway-api.md:159
- This BackendTLSPolicy example omits
gatewayAPI.enabled: true, so the chart will not render BackendTLSPolicy even ifbackendTLSPolicy.enabledis set. Include the top-level enable flag to make the snippet copy/pasteable.
This issue also appears on line 179 of the same file.
gatewayAPI:
core:
backendTLSPolicy:
charts/gitea/docs/gateway-api.md:234
- This override example omits
gatewayAPI.enabled: true. Without it,clientSettingsPolicies.enabledalone will not render the ClientSettingsPolicy resource.
gatewayAPI:
nginx:
clientSettingsPolicies:
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (1)
charts/gitea/README.md:318
- README claims the chart can render an optional
Gateway, butdocs/gateway-api.mdexplicitly states the chart does not render aGatewayresource. This is misleading for users configuring Gateway API exposure.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (8)
charts/gitea/docs/gateway-api.md:31
- The Gateway API examples enable
gatewayAPI.core.httpRoute.enabled/tcpRoute.enabledbut omitgatewayAPI.enabled: true. With the current templates, the routes will not render unlessgatewayAPI.enabledis also set, so the example is not copy/paste-correct.
gatewayAPI:
core:
charts/gitea/docs/gateway-api.md:180
- This BackendTLSPolicy example also omits
gatewayAPI.enabled: true, which is required for the BackendTLSPolicy template to render.
gatewayAPI:
core:
charts/gitea/README.md:318
- The README says the chart can render an optional
Gateway, butdocs/gateway-api.mdexplicitly states the chart does not render aGatewayresource. Also, the README list omitsClientSettingsPolicy, which the chart does render (NGINX Gateway Fabric).
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
charts/gitea/Chart.yaml:8
- The PR title/description indicate this is only a chart dependency bump, but the diff also adds Gateway API support (new templates, values, and docs). Please update the PR description (and possibly the title) to reflect the additional feature so reviewers/users aren’t surprised.
- kind: added
description: add Gateway API support (#1073)
- kind: changed
description: update alpine/helm docker tag to v3.21.3 (#1096)
- kind: changed
description: update to 1.27.0 (#1095)
charts/gitea/docs/gateway-api.md:158
- This BackendTLSPolicy example omits
gatewayAPI.enabled: true. Because the chart gates all Gateway API resources ongatewayAPI.enabled, this configuration will not render the BackendTLSPolicy as written.
This issue also appears on line 179 of the same file.
gatewayAPI:
core:
charts/gitea/docs/gateway-api.md:233
- This ClientSettingsPolicy example omits
gatewayAPI.enabled: true. Without it, theClientSettingsPolicyresource will not render even thoughclientSettingsPolicies.enabled: trueis set.
gatewayAPI:
nginx:
charts/gitea/templates/gitea/backendTLSPolicy.yaml:4
keysexpects a map; if a user setsgatewayAPI.core.backendTLSPolicy.validation: null(or it becomes nil via templating), this will raise a template error instead of producing the intendedfailmessage. Usingemptymakes the check robust for both{}andnull.
{{- if eq (include "gitea.backendTLSPolicy.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }}
{{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }}
{{- end }}
charts/gitea/templates/gitea/clientSettingsPolicy.yaml:4
keysexpects a map; ifgatewayAPI.nginx.clientSettingsPolicies.bodyis set tonull, this will cause a template error instead of the intendedfailmessage.emptycorrectly treats both{}andnullas empty.
{{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}}
{{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }}
{{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }}
{{- end }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency gitea to version 12.7.0.