chore(chart-deps): update tekton-pipelines to version 1.14.0 - #3448
Draft
svcAPLBot wants to merge 24 commits into
Draft
chore(chart-deps): update tekton-pipelines to version 1.14.0#3448svcAPLBot wants to merge 24 commits into
svcAPLBot wants to merge 24 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the vendored Tekton Pipelines Helm chart/dependency from 1.12.0 → 1.14.0, updating images, labels, feature flags, and CRDs to match the newer upstream release.
Changes:
- Updated Tekton component image tags/digests and chart/app versions to 1.14.0.
- Refreshed Tekton Pipelines CRDs and various chart metadata/labels to v1.14.0.
- Added configurable
imagePullSecretsvalues for Tekton controller/webhook/resolvers/events-controller (but the current template rendering needs adjustment).
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/tekton-pipelines/values.yaml | Bumps component images to v1.14.0; adds imagePullSecrets values; adds new feature-flag default. |
| charts/tekton-pipelines/templates/webhook.pipeline.tekton.dev-mutwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/webhook-certs-secret.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/validation.webhook.pipeline.tekton.dev-valwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-horizontalpodautoscaler.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml | Updates version/release labels; adds imagePullSecrets wiring (currently renders unconditionally). |
| charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml | Updates version/release labels; adds imagePullSecrets wiring (currently renders unconditionally). |
| charts/tekton-pipelines/templates/tekton-pipelines-controller-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml | Updates version/release labels; adds imagePullSecrets wiring (currently renders unconditionally). |
| charts/tekton-pipelines/templates/tekton-events-controller-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml | Updates version/release labels; adds imagePullSecrets wiring (currently renders unconditionally). |
| charts/tekton-pipelines/templates/pipelines-info-cm.yaml | Updates reported version to v1.14.0. |
| charts/tekton-pipelines/templates/config.webhook.pipeline.tekton.dev-valwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/config-tracing-cm.yaml | Adds a note about trace data sensitivity (currently references a non-existent repo doc path). |
| charts/tekton-pipelines/crds/verificationpolicies.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/crds/tasks.tekton.dev-crd.yaml | Updates CRD labels; upstream CRD schema adjustments. |
| charts/tekton-pipelines/crds/taskruns.tekton.dev-crd.yaml | Updates CRD labels; adds enableTerminationMessageCompression schema fields. |
| charts/tekton-pipelines/crds/stepactions.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/crds/pipelines.tekton.dev-crd.yaml | Updates CRD labels; updates Pipeline* alpha-field descriptions. |
| charts/tekton-pipelines/crds/pipelineruns.tekton.dev-crd.yaml | Updates CRD labels; adds enableTerminationMessageCompression schema fields. |
| charts/tekton-pipelines/crds/customruns.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/Chart.yaml | Bumps Helm chart version/appVersion to 1.14.0. |
| chart/chart-index/Chart.yaml | Updates the tekton-pipeline dependency version to 1.14.0. |
| apps.yaml | Updates the advertised Tekton appVersion to 1.14.0. |
Comment on lines
+145
to
+148
| imagePullSecrets: | ||
| {{- with .Values.controller.imagePullSecrets }} | ||
| {{- toYaml . | nindent 6 }} | ||
| {{- end }} |
Comment on lines
+130
to
+133
| imagePullSecrets: | ||
| {{- with .Values.webhook.imagePullSecrets }} | ||
| {{- toYaml . | nindent 6 }} | ||
| {{- end }} |
Comment on lines
+111
to
+114
| imagePullSecrets: | ||
| {{- with .Values.remoteresolver.imagePullSecrets }} | ||
| {{- toYaml . | nindent 6 }} | ||
| {{- end }} |
Comment on lines
+104
to
+107
| imagePullSecrets: | ||
| {{- with .Values.eventscontroller.imagePullSecrets }} | ||
| {{- toYaml . | nindent 6 }} | ||
| {{- end }} |
Comment on lines
+15
to
+17
| # NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun | ||
| # names and namespaces) as span attributes. Treat the trace backend as a trusted observability | ||
| # system. See docs/developers/tracing.md for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (5)
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
- The
imagePullSecretsblock is rendered unconditionally and usesnindent 6, which will produce invalid YAML when a list is provided (list items will not be indented underimagePullSecrets). Wrap the whole key in thewithblock and indent list items under the key (typicallynindent 8).
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
- The
imagePullSecretsblock is rendered unconditionally and usesnindent 6, which will produce invalid YAML when a list is provided (list items will not be indented underimagePullSecrets). Wrap the whole key in thewithblock and indent list items under the key (typicallynindent 8).
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
- The
imagePullSecretsblock is rendered unconditionally and usesnindent 6, which will produce invalid YAML when a list is provided (list items will not be indented underimagePullSecrets). Wrap the whole key in thewithblock and indent list items under the key (typicallynindent 8).
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
- The
imagePullSecretsblock is rendered unconditionally and usesnindent 6, which will produce invalid YAML when a list is provided (list items will not be indented underimagePullSecrets). Wrap the whole key in thewithblock and indent list items under the key (typicallynindent 8).
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that file does not exist in this repository, so the reference is currently broken/misleading. Either add the referenced doc or remove the pointer from the NOTE.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (5)
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecrets:is rendered unconditionally, but.Values.webhook.imagePullSecretsdefaults to an empty list, so thewithblock outputs nothing and the manifest ends up withimagePullSecrets: null(invalid type; Kubernetes expects an array). Also, thenindent 6would align list items with the key rather than nesting them.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
imagePullSecrets:is rendered unconditionally, but.Values.remoteresolver.imagePullSecretsdefaults to an empty list, so thewithblock outputs nothing and the manifest ends up withimagePullSecrets: null(invalid type; Kubernetes expects an array). Also,nindent 6would not indent list items under the key.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
imagePullSecrets:is rendered unconditionally, but.Values.controller.imagePullSecretsdefaults to an empty list, so thewithblock outputs nothing and the manifest ends up withimagePullSecrets: null(invalid type; Kubernetes expects an array). Also,nindent 6would not indent list items under the key.
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecrets:is rendered unconditionally, but.Values.eventscontroller.imagePullSecretsdefaults to an empty list, so thewithblock outputs nothing and the manifest ends up withimagePullSecrets: null(invalid type; Kubernetes expects an array). Also,nindent 6would not indent list items under the key.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that file does not exist in the repository, so it’s a broken documentation link in-tree.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
imagePullSecrets:is always rendered, but the list entries are emitted withnindent 6and only inside thewithblock. When the list is empty (default[]), this producesimagePullSecrets:with no value (null), and when non-empty it can also render the list at the wrong indentation level. Both can lead to invalid PodSpec YAML / schema validation errors. Wrap the wholeimagePullSecretsblock in awithand indent list items under the key (consistent with other charts in this repo).
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
imagePullSecrets:is always rendered, but the list entries are emitted withnindent 6and only inside thewithblock. When the list is empty (default[]), this producesimagePullSecrets:with no value (null), and when non-empty it can also render the list at the wrong indentation level. Both can lead to invalid PodSpec YAML / schema validation errors. Wrap the wholeimagePullSecretsblock in awithand indent list items under the key (consistent with other charts in this repo).
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecrets:is always rendered, but the list entries are emitted withnindent 6and only inside thewithblock. When the list is empty (default[]), this producesimagePullSecrets:with no value (null), and when non-empty it can also render the list at the wrong indentation level. Both can lead to invalid PodSpec YAML / schema validation errors. Wrap the wholeimagePullSecretsblock in awithand indent list items under the key (consistent with other charts in this repo).
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that file/path does not exist in this repo. This makes the guidance hard to follow and can confuse operators reviewing the rendered manifests. Either add the referenced doc or remove/replace the pointer with an existing doc path.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecrets:is always rendered, but the list entries are emitted withnindent 6and only inside thewithblock. When the list is empty (default[]), this producesimagePullSecrets:with no value (null), and when non-empty it can also render the list at the wrong indentation level. Both can lead to invalid PodSpec YAML / schema validation errors. Wrap the wholeimagePullSecretsblock in awithand indent list items under the key (consistent with other charts in this repo).
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
imagePullSecrets:is always rendered even when.Values.controller.imagePullSecretsis empty (default[]). That producesimagePullSecrets: nullin the rendered PodSpec, which can fail Kubernetes schema validation. Render the key only when the list is non-empty.
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecrets:is always rendered even when.Values.webhook.imagePullSecretsis empty (default[]). That producesimagePullSecrets: nullin the rendered PodSpec, which can fail Kubernetes schema validation. Render the key only when the list is non-empty.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
imagePullSecrets:is always rendered even when.Values.remoteresolver.imagePullSecretsis empty (default[]). That producesimagePullSecrets: nullin the rendered PodSpec, which can fail Kubernetes schema validation. Render the key only when the list is non-empty.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecrets:is always rendered even when.Values.eventscontroller.imagePullSecretsis empty (default[]). That producesimagePullSecrets: nullin the rendered PodSpec, which can fail Kubernetes schema validation. Render the key only when the list is non-empty.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that path doesn't exist in this repository. Either add the referenced doc or avoid pointing to a missing file to prevent confusion.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (2)
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that path does not exist in this repository. This makes the guidance hard to follow for users editing the ConfigMap.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
charts/tekton-pipelines/Chart.yaml:7
- The chart is bumped to Tekton Pipelines 1.14.0, but the Helmfile values template used for the
tekton-pipelinesrelease still pins Tekton images at v1.12.0. Helmfile-04.init.yaml.gotmpl includes../values/tekton-pipelines/tekton-pipelines.gotmpl, and that file currently sets controller/webhook/resolvers/events images to v1.12.0, which will override the chart’s updated defaults and prevent the intended upgrade.
appVersion: 1.14.0
description: A Helm chart for Tekton Pipelines
home: https://github.com/cdfoundation/tekton-helm-chart
icon: https://avatars2.githubusercontent.com/u/47602533
name: tekton-pipeline
version: 1.14.0
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
- The new imagePullSecrets templating is incorrectly indented (nindent 6), so rendered list items will not be nested under the imagePullSecrets key. Also, emitting the key unconditionally can render a null value when empty; prefer wrapping the whole field in a
withblock as done in other charts in this repo.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
- The new imagePullSecrets templating is incorrectly indented (nindent 6), so rendered list items will not be nested under the imagePullSecrets key. Also, emitting the key unconditionally can render a null value when empty; other charts in this repo wrap the entire field in a
withblock (e.g., charts/argocd/templates/argocd-server/deployment.yaml:50-53).
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
- The new imagePullSecrets templating is incorrectly indented (nindent 6), so rendered list items will not be nested under the imagePullSecrets key. Wrap the entire field in a
withblock and indent list items under the key.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
- The new imagePullSecrets templating is incorrectly indented (nindent 6), so rendered list items will not be nested under the imagePullSecrets key. Wrap the entire field in a
withblock and indent list items under the key.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references docs/developers/tracing.md, but that file does not exist in this repository. Either add the referenced doc or link to upstream Tekton tracing documentation to avoid a dead reference.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (2)
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references docs/developers/tracing.md, but that file does not exist in the repository. Please either add the referenced document or adjust the note to avoid a broken path so users aren’t pointed to non-existent docs.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
charts/tekton-pipelines/Chart.yaml:7
- Although the chart/appVersion is bumped to 1.14.0 here, the Helmfile release for tekton-pipelines pulls values from ../values/tekton-pipelines/tekton-pipelines.gotmpl, which still pins controller/webhook/resolvers/events images to v1.12.0. That means the deployed Tekton images will likely remain at 1.12.0 unless those pinned values are updated as part of this version bump.
appVersion: 1.14.0
description: A Helm chart for Tekton Pipelines
home: https://github.com/cdfoundation/tekton-helm-chart
icon: https://avatars2.githubusercontent.com/u/47602533
name: tekton-pipeline
version: 1.14.0
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that file does not exist in the repository. This makes the guidance a dead link and potentially confusing for operators trying to assess trace data sensitivity.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Comment on lines
25
to
29
| # Values for tekton-pipelines-controller | ||
| controller: | ||
| deployment: | ||
| image: ghcr.io/tektoncd/pipeline/controller-10a3e32792f33651396d02b6855a6e36:v1.12.0@sha256:8d5f900677386b8fe5371429e9c1461b25de47e5e34736c7f99e82e2c279ebbc | ||
| image: ghcr.io/tektoncd/pipeline/controller-10a3e32792f33651396d02b6855a6e36:v1.14.0@sha256:5209c1969c407d36d9c2c5217a8b0700a9fb52b3068b6fbdce0d88ead397ea75 | ||
| labels: {} |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecretsis always rendered (even when the value is empty) and the rendered list indentation is incorrect (nindent 6makes list items align with the key). This can produce invalid YAML / an invalid PodSpec. Wrap the entire field in thewithblock and indent list items under the key.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecretsis rendered even when the value is empty, andnindent 6will indent list items at the same level as theimagePullSecrets:key, which is invalid YAML. Wrap the key in thewithand use a deeper indent for the list items.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
imagePullSecretsis emitted unconditionally and the list indentation is incorrect (nindent 6aligns items with the key). This can render invalid YAML / an invalid PodSpec. Wrap the whole field in thewithblock and indent items underimagePullSecrets:.
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
imagePullSecretsis always output and the list indentation is wrong (nindent 6makes list items align with the key). This can render invalid YAML / an invalid PodSpec. Wrap the entire field in thewithblock and indent list items under the key.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment references
docs/developers/tracing.md, but that path does not exist in this repo. Either add the referenced doc or remove/update the pointer so it doesn’t send readers to a dead link.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecretsis always rendered, but the list content is wrapped in awithblock. Since the default in values.yaml is an empty list ([]), Helm treats it as empty and skips thewith, renderingimagePullSecrets: nullin the PodSpec. This can fail Kubernetes schema validation (expects an array) and is inconsistent with other charts in this repo that only renderimagePullSecretswhen non-empty.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
- Same
imagePullSecretsrendering issue as in the webhook deployment: with the default empty list, this producesimagePullSecrets: null, which may be rejected by the API server and diverges from established templating patterns elsewhere in the repo.
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
imagePullSecretsis always emitted but only populated when the list is non-empty; with the default empty list this renders asnull. Render the key only when.Values.remoteresolver.imagePullSecretsis non-empty (consistent with other charts in this repo) to avoid schema validation issues.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This comment links to
docs/developers/tracing.md, but that file does not exist in the repository. Either add the referenced doc (outside this template) or remove the broken link to avoid sending readers to a dead path.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecretsis rendered unconditionally, but thewithblock will be skipped for the default empty list and produceimagePullSecrets: null. Wrap the whole block inwithso the field is omitted unless configured, matching patterns used elsewhere in this repo.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency tekton-pipeline to version 1.14.0.