chore(chart-deps): update policy-reporter to version 3.8.1 - #3434
chore(chart-deps): update policy-reporter to version 3.8.1#3434svcAPLBot wants to merge 22 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored policy-reporter Helm chart to 3.8.1, aligning chart metadata and dependency pinning while incorporating upstream template/value changes (HTTPRoute backendRefs explicit typing and a new ServiceMonitor enable toggle).
Changes:
- Bump
policy-reporterchartversion/appVersionto 3.8.1 and update thechart-indexdependency pin accordingly. - Update related image tags (UI + plugins) to match the newer chart release.
- Add explicit
group/kindto Gateway APIHTTPRoutebackendRefs, and gateServiceMonitorrendering behindmonitoring.serviceMonitor.enabled(defaulted on).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/policy-reporter/values.yaml | Updates image tag defaults and introduces monitoring.serviceMonitor.enabled (default true). |
| charts/policy-reporter/templates/ui/httproute.yaml | Makes backendRefs explicitly reference a core Service. |
| charts/policy-reporter/templates/plugins/kyverno/httproute.yaml | Makes backendRefs explicitly reference a core Service. |
| charts/policy-reporter/templates/monitoring/servicemonitor.yaml | Adds a template guard requiring monitoring.serviceMonitor.enabled. |
| charts/policy-reporter/templates/httproute.yaml | Makes backendRefs explicitly reference a core Service. |
| charts/policy-reporter/README.md | Updates chart/app versions and documents updated default tags and the new ServiceMonitor toggle (currently with an empty description). |
| charts/policy-reporter/Chart.yaml | Bumps chart version and appVersion to 3.8.1. |
| chart/chart-index/Chart.yaml | Pins the policy-reporter dependency version to 3.8.1. |
| serviceMonitor: | ||
| enabled: true | ||
| # -- HonorLabels chooses the metrics labels on collisions with target labels |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
charts/policy-reporter/values.yaml:1873
monitoring.serviceMonitor.enabledwas added with defaulttrue, but it lacks the usual# -- (...)documentation comment used throughout this values file. Adding the comment keeps the chart values self-documenting and aligns with the README table generation.
serviceMonitor:
enabled: true
charts/policy-reporter/README.md:636
- The new
monitoring.serviceMonitor.enabledvalue is documented in the parameters table but the description cell is empty, which makes the generated documentation unclear. Add a short description (and ideally mention it is gated bymonitoring.enabled).
| monitoring.serviceMonitor.enabled | bool | `true` | |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
charts/policy-reporter/values.yaml:1873
monitoring.serviceMonitor.enabledwas added without a# --doc comment, which results in an empty description in the generated/maintained values documentation. Add a short comment describing what the flag does and that it is gated bymonitoring.enabled.
serviceMonitor:
enabled: true
charts/policy-reporter/README.md:636
- The README values table row for
monitoring.serviceMonitor.enabledhas an empty description, which makes the rendered chart docs less useful. Fill in a short description consistent withvalues.yaml.
| monitoring.serviceMonitor.enabled | bool | `true` | |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (2)
charts/policy-reporter/values.yaml:1875
monitoring.serviceMonitor.enabledwas added, but it lacks a# --doc comment in values.yaml. This causes the README table entry to have an empty description and makes the option harder to discover/understand.
serviceMonitor:
enabled: true
# -- HonorLabels chooses the metrics labels on collisions with target labels
honorLabels: false
charts/policy-reporter/README.md:636
- The new
monitoring.serviceMonitor.enabledrow in the values table has an empty description, which makes the generated documentation less useful. Add a short description consistent with surrounding rows.
| monitoring.serviceMonitor.enabled | bool | `true` | |
This PR updates the dependency policy-reporter to version 3.8.1.